Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: use valid wallet addresses #2538

Merged
merged 4 commits into from
Jul 28, 2020
Merged

Conversation

goga-m
Copy link
Contributor

@goga-m goga-m commented Jul 28, 2020

Summary

Correct ark wallet id/address references in tests.
Prevents platform-sdk errors e.g Failed to find a wallet for [1ASuusXSW9kfWnicScSgUTjttP6T9GQ3kqT]

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@goga-m goga-m requested a review from faustbrian as a code owner July 28, 2020 07:09
@ghost ghost added Complexity: High More than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jul 28, 2020
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #2538 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2538     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       253    +229     
  Lines            142      2758   +2616     
  Branches          18       494    +476     
=============================================
+ Hits             142      2758   +2616     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/components/Card/CardControl.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Checkbox/Checkbox.tsx 100.00% <100.00%> (ø)
... and 274 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c17cb...88041aa. Read the comment docs.

@faustbrian faustbrian merged commit 9939787 into 3.0-react Jul 28, 2020
@ghost ghost deleted the fix/use-valid-wallet-addresses branch July 28, 2020 07:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants