Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: sync wallet data #2748

Merged
merged 29 commits into from
Sep 1, 2020
Merged

feat: sync wallet data #2748

merged 29 commits into from
Sep 1, 2020

Conversation

clucasalcantara
Copy link
Contributor

Summary

  • Replace sync votes and sync identity per initialize run
  • Add syncExchangeRate to the wallet data sync
  • Add scheduler service to run syncs periodically and persist when timers run

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@clucasalcantara clucasalcantara self-assigned this Aug 28, 2020
@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Feature The issue is a request for new functionality. Status: In Progress The issue or pull request is being worked on. labels Aug 28, 2020
@@ -0,0 +1,12 @@
export const Scheduler = (interval = 300000) => ({
Copy link
Contributor

@faustbrian faustbrian Aug 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functions should always be camelCase and classes PascalClass.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think that we should create a class instead of just a function in this case to explicit that the Scheduler should be service/module ? 🤔

@faustbrian
Copy link
Contributor

faustbrian commented Aug 29, 2020

After this PR there should be another PR to include https://github.com/ArkEcosystem/platform-sdk/releases/tag/0.9.318 and https://github.com/ArkEcosystem/platform-sdk/releases/tag/0.9.319 in the same way as delegate syncing to avoid constantly fetching fees when a user moves to a transaction send page.

src/app/App.tsx Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #2748 into 3.0-react will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           3.0-react     #2748     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
=============================================
  Files             24       275    +251     
  Lines            142      3920   +3778     
  Branches          18       702    +684     
=============================================
+ Hits             142      3920   +3778     
Flag Coverage Δ
#unit 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Button/Button.tsx 100.00% <ø> (ø)
src/app/App.tsx 100.00% <100.00%> (ø)
src/app/components/Address/Address.tsx 100.00% <100.00%> (ø)
src/app/components/Alert/Alert.tsx 100.00% <100.00%> (ø)
src/app/components/Amount/Amount.tsx 100.00% <100.00%> (ø)
src/app/components/Avatar/Avatar.tsx 100.00% <100.00%> (ø)
src/app/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/app/components/Breadcrumbs/Breadcrumbs.tsx 100.00% <100.00%> (ø)
src/app/components/Card/Card.tsx 100.00% <100.00%> (ø)
src/app/components/Card/CardControl.tsx 100.00% <100.00%> (ø)
... and 295 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1b5434...0756d25. Read the comment docs.

src/app/App.tsx Outdated Show resolved Hide resolved
@faustbrian faustbrian marked this pull request as ready for review September 1, 2020 14:27
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Sep 1, 2020
@faustbrian faustbrian merged commit 2f26e56 into 3.0-react Sep 1, 2020
@ghost ghost deleted the feat/sync-wallet-data branch September 1, 2020 14:28
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Sep 1, 2020
@goga-m goga-m mentioned this pull request Sep 1, 2020
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants