-
Notifications
You must be signed in to change notification settings - Fork 192
Conversation
@@ -0,0 +1,12 @@ | |||
export const Scheduler = (interval = 300000) => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functions should always be camelCase
and classes PascalClass
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think that we should create a class instead of just a function in this case to explicit that the Scheduler should be service/module
? 🤔
After this PR there should be another PR to include https://github.com/ArkEcosystem/platform-sdk/releases/tag/0.9.318 and https://github.com/ArkEcosystem/platform-sdk/releases/tag/0.9.319 in the same way as delegate syncing to avoid constantly fetching fees when a user moves to a transaction send page. |
Codecov Report
@@ Coverage Diff @@
## 3.0-react #2748 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 24 275 +251
Lines 142 3920 +3778
Branches 18 702 +684
=============================================
+ Hits 142 3920 +3778
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Summary
Checklist