Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: blacklist a plugin #2864

Merged
merged 24 commits into from
Sep 30, 2020
Merged

feat: blacklist a plugin #2864

merged 24 commits into from
Sep 30, 2020

Conversation

clucasalcantara
Copy link
Contributor

@clucasalcantara clucasalcantara commented Sep 23, 2020

Summary

  • Adds SDK integration to add a plugin to the profile blacklist

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@clucasalcantara clucasalcantara self-assigned this Sep 23, 2020
@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Feature The issue is a request for new functionality. Status: In Progress The issue or pull request is being worked on. labels Sep 23, 2020
@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #2864 into develop will increase coverage by 41.07%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           develop     #2864       +/-   ##
=============================================
+ Coverage    58.92%   100.00%   +41.07%     
=============================================
  Files          373       342       -31     
  Lines         9325      4828     -4497     
  Branches      1934       876     -1058     
=============================================
- Hits          5495      4828      -667     
+ Misses        3603         0     -3603     
+ Partials       227         0      -227     
Flag Coverage Δ
#unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/App.tsx 100.00% <ø> (ø)
...rc/renderer/services/synchronizer/announcements.js
src/renderer/models/delegate.js
src/renderer/services/synchronizer/wallets.js
src/renderer/pages/Profile/ProfileAll.vue
...uginManager/PluginManagerModals/PluginUrlModal.vue
src/renderer/components/Modal/ModalPeer.vue
src/renderer/store/modules/plugin.js
src/renderer/store/modules/app.js
.../TransactionForm/TransactionFormBusiness/mixin.vue
... and 706 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ddc65f...affea0b. Read the comment docs.

@faustbrian faustbrian changed the base branch from 3.0-react to develop September 28, 2020 08:55
@clucasalcantara clucasalcantara marked this pull request as ready for review September 28, 2020 12:13
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Sep 28, 2020
@faustbrian faustbrian merged commit 9d7889a into develop Sep 30, 2020
@ghost ghost deleted the feat/plugin-blacklisting branch September 30, 2020 02:06
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants