Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: limit networks with profile wallets #2950

Merged
merged 25 commits into from
Oct 16, 2020
Merged

Conversation

clucasalcantara
Copy link
Contributor

@clucasalcantara clucasalcantara commented Oct 8, 2020

Summary

Solves: https://app.clickup.com/t/90q0t1

  • While sending money, limit the available networks to the profile wallets coins

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@clucasalcantara clucasalcantara self-assigned this Oct 8, 2020
@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. Status: In Progress The issue or pull request is being worked on. labels Oct 8, 2020
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #2950 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop     #2950   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          365       365           
  Lines         5186      5207   +21     
  Branches       956       955    -1     
=========================================
+ Hits          5186      5207   +21     
Flag Coverage Δ
#unit 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...network/components/SelectNetwork/SelectNetwork.tsx 100.00% <100.00%> (ø)
...onents/SendTransactionForm/SendTransactionForm.tsx 100.00% <100.00%> (ø)
.../SendEntityRegistration/SendEntityRegistration.tsx 100.00% <100.00%> (ø)
src/domains/vote/pages/Votes/Votes.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e126a7a...6d03f0c. Read the comment docs.

@clucasalcantara clucasalcantara marked this pull request as ready for review October 8, 2020 14:55
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Oct 8, 2020
@clucasalcantara clucasalcantara marked this pull request as draft October 8, 2020 21:01
@clucasalcantara clucasalcantara marked this pull request as ready for review October 9, 2020 13:40
Copy link
Contributor

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clucasalcantara - Can this change also be applied to the 'My Votes' and 'Registration' pages. So the user can only select cryptoasset that belongs to their profile to register or vote with please?

@clucasalcantara
Copy link
Contributor Author

@clucasalcantara - Can this change also be applied to the 'My Votes' and 'Registration' pages. So the user can only select cryptoasset that belongs to their profile to register or vote with please?

@samharperpittam updated, "My Votes" page (from navbar) and send registration page with networks filtered (only cryptoassets available in the user profile)

@faustbrian faustbrian merged commit a1da369 into develop Oct 16, 2020
@ghost ghost deleted the fix/send-transfer-networks branch October 16, 2020 01:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Status: Needs Review The issue or pull request needs a review by a developer of the team. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants