Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Address on type checks in send dialog #499

Merged
merged 1 commit into from
Jan 6, 2018

Conversation

Nasicus
Copy link

@Nasicus Nasicus commented Jan 4, 2018

We now have the following states:

Invalid Address (error, send is disabled):
1

Address is own address (warning, send is enabled):
2

Address doesn't have any transaction / doesn't exist (info, send is enabled):
3

Address is neo address (warning, send is enabled):
=> should we display it as an error or as a warning? (and disable send button) I think warning is correct.
4

... and of course, the state when everything is fine:
5

Addresses: #489

@fix
Copy link

fix commented Jan 4, 2018

well done @Nasicus for this NEO address pinging

What i am not sure is if same publickey gives same address, if yes i guess we could lock down the 'send' button if a NEO address is matched

@Nasicus
Copy link
Author

Nasicus commented Jan 5, 2018

@fix
Thanks.
Even if it would: Wouldn't the possibility of generating the same address be impossible small anyway? If so you're right and showing and error + disabling the button would be better.

(Will resolve the conflicts this evening)

@luciorubeens
Copy link
Contributor

NEO uses elliptic curve secp256r1, and ARK uses secp256k1. So the private key will be different.

@Nasicus
Copy link
Author

Nasicus commented Jan 5, 2018

But getting the same addresses should still be nearly impossible? (Sorry I'm not really "educated" in this whole area :) )
And what does this mean concerning if it should be warning or an error? :D

- delete unused controller
@luciorubeens luciorubeens merged commit 88d9e0c into ArkEcosystem:master Jan 6, 2018
@luciorubeens
Copy link
Contributor

Well, they use a different mechanism, so the same publicKey will generate different addresses. But yes, it's possible to have the same address in both blockchains. Looks good, good job! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants