New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address on type checks in send dialog #499

Merged
merged 1 commit into from Jan 6, 2018

Conversation

Projects
None yet
4 participants
@Nasicus
Contributor

Nasicus commented Jan 4, 2018

We now have the following states:

Invalid Address (error, send is disabled):
1

Address is own address (warning, send is enabled):
2

Address doesn't have any transaction / doesn't exist (info, send is enabled):
3

Address is neo address (warning, send is enabled):
=> should we display it as an error or as a warning? (and disable send button) I think warning is correct.
4

... and of course, the state when everything is fine:
5

Addresses: #489

@fix

This comment has been minimized.

Show comment
Hide comment
@fix

fix Jan 4, 2018

Member

well done @Nasicus for this NEO address pinging

What i am not sure is if same publickey gives same address, if yes i guess we could lock down the 'send' button if a NEO address is matched

Member

fix commented Jan 4, 2018

well done @Nasicus for this NEO address pinging

What i am not sure is if same publickey gives same address, if yes i guess we could lock down the 'send' button if a NEO address is matched

@Nasicus

This comment has been minimized.

Show comment
Hide comment
@Nasicus

Nasicus Jan 5, 2018

Contributor

@fix
Thanks.
Even if it would: Wouldn't the possibility of generating the same address be impossible small anyway? If so you're right and showing and error + disabling the button would be better.

(Will resolve the conflicts this evening)

Contributor

Nasicus commented Jan 5, 2018

@fix
Thanks.
Even if it would: Wouldn't the possibility of generating the same address be impossible small anyway? If so you're right and showing and error + disabling the button would be better.

(Will resolve the conflicts this evening)

@luciorubeens

This comment has been minimized.

Show comment
Hide comment
@luciorubeens

luciorubeens Jan 5, 2018

Member

NEO uses elliptic curve secp256r1, and ARK uses secp256k1. So the private key will be different.

Member

luciorubeens commented Jan 5, 2018

NEO uses elliptic curve secp256r1, and ARK uses secp256k1. So the private key will be different.

@Nasicus

This comment has been minimized.

Show comment
Hide comment
@Nasicus

Nasicus Jan 5, 2018

Contributor

But getting the same addresses should still be nearly impossible? (Sorry I'm not really "educated" in this whole area :) )
And what does this mean concerning if it should be warning or an error? :D

Contributor

Nasicus commented Jan 5, 2018

But getting the same addresses should still be nearly impossible? (Sorry I'm not really "educated" in this whole area :) )
And what does this mean concerning if it should be warning or an error? :D

check ark address in send dialog
- delete unused controller

@luciorubeens luciorubeens merged commit 88d9e0c into ArkEcosystem:master Jan 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@luciorubeens

This comment has been minimized.

Show comment
Hide comment
@luciorubeens

luciorubeens Jan 6, 2018

Member

Well, they use a different mechanism, so the same publicKey will generate different addresses. But yes, it's possible to have the same address in both blockchains. Looks good, good job! 👍

Member

luciorubeens commented Jan 6, 2018

Well, they use a different mechanism, so the same publicKey will generate different addresses. But yes, it's possible to have the same address in both blockchains. Looks good, good job! 👍

@Nasicus Nasicus deleted the Nasicus:feat/check-ark-address branch Jan 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment