We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expected Behavior
Installing core with the RPC module should allow users to communicate with the node and the network that the node is using.
Current Behavior
Instead of connecting to the network of the node, it grabs hard-coded values from 'exchange-json-rpc' that pulls data from the Ark network.
The package.json in 'core-exchange-json-rpc' shows a dependency called 'exchange-json-rpc' at line 24.
Heading over to this dependency in the 'network.ts' file, it pulls network data from Ark peers: https://github.com/ArkEcosystem/exchange-json-rpc/blob/master/packages/rpc/src/services/network.ts
At line: 112 and 122.
Possible Solution
It should take the peers and port from a local folder or config file. Probably in this format: ${resolve(process.env.CORE_PATH_CONFIG)}/peers.json
${resolve(process.env.CORE_PATH_CONFIG)}/peers.json
Steps to Reproduce (for bugs)
(any other command, like blockheight, network information etc will also return data from the Ark blockchain)
Context
Was trying to help TradeSatoshi integrate a bridgechain on their exchange using RPC.
Your Environment
Used core-control to install the node.
The text was updated successfully, but these errors were encountered:
Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.
If no reviewer appears after a week, a reminder will be sent out.
Sorry, something went wrong.
No branches or pull requests
Expected Behavior
Installing core with the RPC module should allow users to communicate with the node and the network that the node is using.
Current Behavior
Instead of connecting to the network of the node, it grabs hard-coded values from 'exchange-json-rpc' that pulls data from the Ark network.
The package.json in 'core-exchange-json-rpc' shows a dependency called 'exchange-json-rpc' at line 24.
Heading over to this dependency in the 'network.ts' file, it pulls network data from Ark peers:
https://github.com/ArkEcosystem/exchange-json-rpc/blob/master/packages/rpc/src/services/network.ts
At line: 112 and 122.
Possible Solution
It should take the peers and port from a local folder or config file.
Probably in this format:
${resolve(process.env.CORE_PATH_CONFIG)}/peers.json
Steps to Reproduce (for bugs)
(any other command, like blockheight, network information etc will also return data from the Ark blockchain)
Context
Was trying to help TradeSatoshi integrate a bridgechain on their exchange using RPC.
Your Environment
Used core-control to install the node.
The text was updated successfully, but these errors were encountered: