Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AIP-11 Support #10

Closed
sleepdefic1t opened this issue Aug 30, 2019 · 5 comments
Closed

Implement AIP-11 Support #10

sleepdefic1t opened this issue Aug 30, 2019 · 5 comments
Labels
Type: Feature The issue is a request for new functionality.

Comments

@sleepdefic1t
Copy link
Contributor

sleepdefic1t commented Aug 30, 2019

Implement Ledger-Transport sending payloads in the official AIP-11 Serialization schemes.

@sleepdefic1t sleepdefic1t added Type: Standards The issue reports problems with the compliance of contribution guidelines or code standards. and removed Type: Standards The issue reports problems with the compliance of contribution guidelines or code standards. labels Aug 30, 2019
@alexbarnsley
Copy link
Member

I think this issue is better off in the ledger repo. The bulk of the changes will be required there as per your statement This Ledger-Transport scheme is also used Ledger-side at Tx deserialization.

IMO this issue is overly complicated/wordy, especially when C is included.

@sleepdefic1t
Copy link
Contributor Author

sleepdefic1t commented Sep 16, 2019

I disagree.

The HW side changes are almost complete.

All we need is for this JS package to send payloads using the official scheme at a minimum.

The big scary “C” examples were only to illustrate that the payload is incorrectly encoded.

I can edit this issue or make another issue that’s easier to understand and doesn’t use C as an example, but I’d still say a request for changes in the Transport package should be in the Transport repo.

@alexbarnsley
Copy link
Member

I'm happy for it to remain open (hence why I didn't close it). It needs editing to remove the "big scary C", because this is a JS repo - either use JS, pseudo-code or English. Also, terminology such as "serde" doesn't make sense to those who don't know them, so you should avoid using short-hand phrases in this sort of environment.

@sleepdefic1t sleepdefic1t changed the title Incorrect Tx Serialization Implement AIP-11 Support Sep 16, 2019
@sleepdefic1t
Copy link
Contributor Author

updated 👍

@sleepdefic1t sleepdefic1t added the Type: Feature The issue is a request for new functionality. label Sep 16, 2019
@alexbarnsley
Copy link
Member

thanks 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

No branches or pull requests

2 participants