-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement AIP-11 Support #10
Comments
I think this issue is better off in the ledger repo. The bulk of the changes will be required there as per your statement IMO this issue is overly complicated/wordy, especially when C is included. |
I disagree. The HW side changes are almost complete. All we need is for this JS package to send payloads using the official scheme at a minimum. The big scary “C” examples were only to illustrate that the payload is incorrectly encoded. I can edit this issue or make another issue that’s easier to understand and doesn’t use C as an example, but I’d still say a request for changes in the Transport package should be in the Transport repo. |
I'm happy for it to remain open (hence why I didn't close it). It needs editing to remove the "big scary C", because this is a JS repo - either use JS, pseudo-code or English. Also, terminology such as "serde" doesn't make sense to those who don't know them, so you should avoid using short-hand phrases in this sort of environment. |
updated 👍 |
thanks 👌 |
Implement Ledger-Transport sending payloads in the official AIP-11 Serialization schemes.
The text was updated successfully, but these errors were encountered: