Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor: replace AbstractFactory with CoinFactory #247

Merged
merged 3 commits into from
May 16, 2020
Merged

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented May 16, 2020

Resolves #245

import { CoinFactory } from "@arkecosystem/platform-sdk";
import { Services } from "@arkecosystem/platform-sdk-ark";

await CoinFactory.construct(ARK, { ... });

Still pondering if there is a better way for the arguments to combine them into a single object.

@codecov
Copy link

codecov bot commented May 16, 2020

Codecov Report

Merging #247 into master will decrease coverage by 2.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   83.30%   81.13%   -2.18%     
==========================================
  Files          25       25              
  Lines         707      774      +67     
  Branches       78      100      +22     
==========================================
+ Hits          589      628      +39     
- Misses        116      144      +28     
  Partials        2        2              
Impacted Files Coverage Δ
src/services/link.ts 0.00% <0.00%> (-62.50%) ⬇️
src/services/transaction.ts 56.73% <0.00%> (-8.13%) ⬇️
src/services/fee.ts 88.23% <0.00%> (-5.89%) ⬇️
src/services/peer.ts 94.73% <0.00%> (-1.32%) ⬇️
src/factory.ts
src/services/identity/utils.ts 100.00% <0.00%> (ø)
src/services/client.ts 86.53% <0.00%> (+0.10%) ⬆️
src/dto/transaction.ts 91.30% <0.00%> (+0.19%) ⬆️
src/services/identity/private-key.ts 92.85% <0.00%> (+0.54%) ⬆️
src/services/identity/public-key.ts 94.73% <0.00%> (+1.40%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c9c9f6...de679be. Read the comment docs.

@faustbrian faustbrian merged commit 111ee2d into master May 16, 2020
@faustbrian faustbrian deleted the factory-coins branch May 16, 2020 02:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce Factory duplication
1 participant