Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: formatting and coverage #111

Merged
merged 6 commits into from
Aug 19, 2019
Merged

style: formatting and coverage #111

merged 6 commits into from
Aug 19, 2019

Conversation

sleepdefic1t
Copy link
Contributor

This PR is primarily concerned with fixing issues found in Codacy/Codefactor/Codecov/Google C++ Style Guide/etc.

This PR also merges #108 & #109 from master.

What kind of change does this PR introduce?

  • Code style update

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Standards The issue reports problems with the compliance of contribution guidelines or code standards. Status: In Progress The issue or pull request is being worked on. labels Aug 3, 2019
@codecov-io
Copy link

codecov-io commented Aug 3, 2019

Codecov Report

Merging #111 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #111    +/-   ##
=======================================
  Coverage      100%   100%            
=======================================
  Files           15     16     +1     
  Lines          249    369   +120     
=======================================
+ Hits           249    369   +120
Impacted Files Coverage Δ
src/include/cpp-client/http/http.h 100% <ø> (ø) ⬆️
src/include/cpp-client/api/abstract.h 100% <100%> (ø) ⬆️
src/include/cpp-client/host/host.h 100% <100%> (ø)
src/include/cpp-client/api/peers/peers.h 100% <100%> (ø) ⬆️
...include/cpp-client/api/transactions/transactions.h 100% <100%> (ø) ⬆️
...c/include/cpp-client/api/blockchain/blockchain.hpp 100% <100%> (ø) ⬆️
src/include/cpp-client/connection/connection.h 100% <100%> (ø) ⬆️
src/http/os/http.cpp 100% <100%> (ø) ⬆️
src/host/host.cpp 100% <100%> (ø) ⬆️
src/include/cpp-client/api/votes/votes.h 100% <100%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da4bf7e...ec2681a. Read the comment docs.

@sleepdefic1t sleepdefic1t changed the title [WIP]style: formatting and coverage style: formatting and coverage Aug 3, 2019
@sleepdefic1t sleepdefic1t marked this pull request as ready for review August 3, 2019 01:19
@sleepdefic1t
Copy link
Contributor Author

sleepdefic1t commented Aug 3, 2019

Codacy isn't configured for tracking develop.
Current build can be seen here: codacy.com/project/sleepdefic1t/cpp-client.
The only issues are related to the changelog, but it's pretty much exactly what's at keepachangelog.com. Changelog would likely need ignored in Codacy settings.

Otherwise, coverage stays at 100%, updates are in place and tests are passing.

This should be good to go, @faustbrian .

@sleepdefic1t
Copy link
Contributor Author

This one's good to go too, @faustbrian.
Please and thank you.

@faustbrian
Copy link
Contributor

@sleepdefic1t conflicts

faustbrian and others added 4 commits August 14, 2019 08:17
This PR is primarily concerned with fixing issues found in Codacy/Codefactor/Codecov/Google C++ Style Guide/etc.
removed duplicate shebang
@sleepdefic1t
Copy link
Contributor Author

@faustbrian
Codacy is still throwing a fit over CHANGELOG here.

This one's ready to go 👍

@faustbrian faustbrian merged commit a842a54 into ArkEcosystemArchive:develop Aug 19, 2019
@ghost ghost removed the Status: In Progress The issue or pull request is being worked on. label Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Standards The issue reports problems with the compliance of contribution guidelines or code standards.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants