[WIP]chore: move dependencies out of source. #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moves submodules/deps to `extern` dir at root. - moves building out of source tree to `build` dir at root. - updates Cmake and PlatformIO build configs. - updates documentation. - updates changelog.
ghost
added
Complexity: Low
sleepdefic1t
changed the title
ghost
mentioned this pull request
- moves submodules/deps to `extern` dir at root. - moves building out of source tree to `build` dir at root. - updates Cmake and PlatformIO build configs. - updates documentation. - updates changelog.
also rm -DBUILD_TESTING=OFF flag
…/cpp-client into chore/move-deps-oos
ghost
removed
the
Status: In Progress
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the build process and dependencies out of the source tree.
Specifically, this PR does the following.
externdir at root.builddir at root.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
The PR fulfills these requirements:
developbranch, not themasterbranch