fix: arduino get/post #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary This PR fixes invalid URL construction and simplifies how the HTTP Get/Post calls are handled in Arduino environments. This PR also does the following: - fixes a typo in the ESP32 Demo Sketch. - uses strings for Path bases vs raw pointers to improve stability. - adds 80 char divider in updated files. ## Checklist - [x] Ready to be merged
sleepdefic1t
requested review from
faustbrian,
kristjank and
spkjp
as code owners
ghost
added
Complexity: High
ciband
approved these changes
Oct 31, 2019
|
@faustbrian This one is ready to go. |
ghost
mentioned this pull request
|
@faustbrian gtg 👍 |
faustbrian
approved these changes
Nov 14, 2019
faustbrian
added
the
Bounty: Tier 4
sleepdefic1t
removed
the
Bounty: Tier 4
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes invalid URL construction and simplifies how the HTTP Get/Post calls are handled in Arduino environments.
This PR also does the following:
- adds 80 char divider in updated files.
Checklist