Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cmake example #25

Merged

Conversation

ciband
Copy link
Contributor

@ciband ciband commented Nov 30, 2018

Proposed changes

Added a standalone example for how to use cpp-client. Top level example directory can be pulled out of the cpp-client source tree and be used as a started point for a new project.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

N/A

ciband and others added 6 commits November 30, 2018 06:54
Added new ArkClient.h in the location that Arduino IDE demands.  This new header just includes the previous header as an adapter layer.
sleepdefic1t
sleepdefic1t previously approved these changes Nov 30, 2018
Copy link
Contributor

@sleepdefic1t sleepdefic1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was updated to remove the Arduino support fix, as it will be resolved in a later PR.

Everything else looks good 👍

@sleepdefic1t
Copy link
Contributor

Mac test issue discussed at ArkEcosystem/Cpp-Crypto Issue #27.

This can now be merged @faustbrian

@faustbrian faustbrian merged commit d04661b into ArkEcosystemArchive:master Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants