Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update codecov to ignore extras directory #32

Merged
merged 1 commit into from
Dec 3, 2018
Merged

chore: Update codecov to ignore extras directory #32

merged 1 commit into from
Dec 3, 2018

Conversation

ciband
Copy link
Contributor

@ciband ciband commented Nov 30, 2018

Proposed changes

Extras directory should be ignore in code coverage calculations. This was missed in the #31.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe: Code coverage accuracy

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

N/A

@ciband
Copy link
Contributor Author

ciband commented Nov 30, 2018

macOS build issues due to #27

sleepdefic1t
sleepdefic1t approved these changes Nov 30, 2018
View reviewed changes
Copy link
Contributor

@sleepdefic1t sleepdefic1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

This can be merged.

@faustbrian faustbrian merged commit d4324c3 into ArkEcosystemArchive:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faustbrian faustbrian faustbrian approved these changes

@sleepdefic1t sleepdefic1t sleepdefic1t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ciband @sleepdefic1t @faustbrian