This repository has been archived by the owner on Oct 8, 2019. It is now read-only.
Feauture: Implementation of Ledger device support #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… connected Ledger device
CryptologySAC
changed the title
Ledger implementation vote and unvote methods
Chore: ledgerark cleanup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of the Ledger device service:
Still had to use the old "ledgerco" npm package (as in the old CLI), because the newer version uses ES6 syntax that is not activated by default in Node. If we want to use the newer version, or the completely new implementation by LedgerHQ, we should consider implementing something like babel-cli.
Implemented a command "Ledger" that shows the status of all wallets on a connected Ledger device.
// TODO: implement transactions with the Ledger and add them to the commands.