Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a typescript version of an existing component #70

Open
the-halfbloodprince opened this issue Oct 12, 2021 · 13 comments · Fixed by #72
Open

Add a typescript version of an existing component #70

the-halfbloodprince opened this issue Oct 12, 2021 · 13 comments · Fixed by #72

Comments

@the-halfbloodprince
Copy link
Contributor

Add a typescript version of an existing component in the same folder.

Since there are multiple components already, multiple individuals can participate in it and take any component you would like to convert.

@shreyavi
Copy link
Contributor

@the-halfbloodprince I created a PR for creating a button tsx component, please take a look

@Yugal41735
Copy link
Contributor

Hello, I would like to contribute but I am a complete beginner, could I still be able to contribute in this issue?

@the-halfbloodprince
Copy link
Contributor Author

Yes @Yugal41735 we would love to have your contribution. The goal is to have the work done irrespective of who you are or how much you know. 😊😊

@Yugal41735
Copy link
Contributor

Thank u. 😊, So could u like elaborate a little what i had to do, and I am willing to learn, so if u know some resouces from where i could learn and contribute in this issue, it would be great.

@the-halfbloodprince
Copy link
Contributor Author

Depends on what you want to contribute to, for this issue you might look up about typescript and probably learn how to convert jsx components to tax... Just google it

@Yugal41735
Copy link
Contributor

Could u tell me which components I have to convert from jsx to tsx.

@the-halfbloodprince
Copy link
Contributor Author

the-halfbloodprince commented Oct 15, 2021

@Yugal41735 you can pick any component you want out of the ones present in the src/components folder

@kannananil
Copy link

I would like to work on this issue, but after cloning the repo and while running yarn for installing the packages I am getting an error. Could someone please help us with this, is there anyone else also getting the same error?

Error got while running the yarn command.
Screenshot 2021-10-18 at 12 48 56 PM

Error details in yarn_error.log
Screenshot 2021-10-18 at 12 52 00 PM

@Pravitha-o-p
Copy link

Pravitha-o-p commented Oct 18, 2021

@anil-muraleedharan I’m also getting the same issue

@the-halfbloodprince
Copy link
Contributor Author

Sorry guys, let me have a look myself. Hold on till then.

@the-halfbloodprince
Copy link
Contributor Author

the-halfbloodprince commented Oct 18, 2021

@anil-muraleedharan , @Pravitha-o-p take a look now, fixed it in #75 . Do let me know if it's working for you.

VedanthB added a commit to VedanthB/artix-component-library that referenced this issue Oct 18, 2021
@VedanthB
Copy link
Contributor

@the-halfbloodprince
I created a PR for creating a AppBar tsx component, please take a look

the-halfbloodprince added a commit that referenced this issue Oct 18, 2021
Created AppBar typescript file. Issue #70
VedanthB added a commit to VedanthB/artix-component-library that referenced this issue Oct 18, 2021
@VedanthB
Copy link
Contributor

VedanthB commented Oct 18, 2021

@the-halfbloodprince
I created a PR for creating a Backdrop and and Badge tsx component as well, please take a look

VedanthB added a commit to VedanthB/artix-component-library that referenced this issue Oct 18, 2021
the-halfbloodprince added a commit that referenced this issue Oct 18, 2021
Created Badge typescript. issue #70
the-halfbloodprince added a commit that referenced this issue Oct 18, 2021
Created Backdrop typescript file. Issue #70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants