This repository was archived by the owner on Jan 16, 2024. It is now read-only.
Update to React v0.13 typings #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The main React typings for v0.13 declare an external module rather than one which declares the internal module React in the global namespace. * Adjust the '<reference path' lines in the .d.ts files generated by TypeScript rather than removing them, as dts-bundle needs to know about them. See Asana#45
|
Thanks! This is awesome! |
pspeter3
added a commit
that referenced
this pull request
Mar 15, 2015
Update to React v0.13 typings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates typed-react to work with the current React v0.13 typings from DefinitelyTyped
The main change is that the current typings declare an external "react" module rather than declaring React in the global namespace, although both flavors of the typings are available in the DefinitelyTyped repository.
Although it is possible to skip typed-react and just use ES6 classes directly, this is still helpful for places where mixin support is useful since that story hasn't been figured out yet, and in my case for migrating a reasonable-size existing codebase to ES6 classes.
external module rather than one which declares
the internal module React in the global namespace.
by TypeScript rather than removing them, as dts-bundle
now needs to know about them
See #45