Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n - Missing Korean translation strings: page.about.* #245

Closed
dzc34 opened this issue Apr 15, 2020 · 1 comment
Closed

i18n - Missing Korean translation strings: page.about.* #245

dzc34 opened this issue Apr 15, 2020 · 1 comment
Labels
Milestone

Comments

@dzc34
Copy link
Member

dzc34 commented Apr 15, 2020

Missing Korean translation strings
on this following URL: https://app.contrast-finder.org/about.html?lang=ko

i18n file: /webapp/src/main/resources/i18n/contrast-finder_utf8_ko.properties

between line 28 and line 30

#form.currentRatio=Current ratio:
#form.currentRatio.alt.valid=The contrast of your colours is sufficient.
#form.currentRatio.alt.fail=The contrast of your colours is insufficient.

and between line 78 and line 102

# page.result-error.titleTag=Error
(...)
# page.about.links=You will find more information in english on the project website (...)
# page.about.fileList.title=Additional files
# page.about.build.title=Build info
# page.about.build.version=version:
# page.about.build.gitBranch=git branch:
# page.about.build.gitCommit=git commit:
# page.about.build.build=Build:
# page.about.build.date=date:
# page.about.build.id=ID:
# page.about.build.platform=Platform:
# page.about.availableLanguages=Available languages
@dzc34 dzc34 added the i18n label Apr 15, 2020
@dzc34
Copy link
Member Author

dzc34 commented Apr 15, 2020

ping @miname, if you have some time ?

miname added a commit to miname/Contrast-Finder that referenced this issue Apr 16, 2020
Correct some expressions more natural.
@dzc34 dzc34 closed this as completed in 6fda0af Apr 16, 2020
@dzc34 dzc34 added this to the 0.10.1 (next) milestone May 23, 2020
dzc34 added a commit that referenced this issue May 23, 2020
-----------------------

  set version to 0.10.1
  FIX: upgrade spring-security (4.2.16 instead of 4.2.14)
  FIX: upgrade springframework (4.3.27 instead of 4.3.26)
  CHORE: upgrade owasp dependency-check plugin (5.3.2 instead of 5.3.1)
  CHORE: upgrade markdown-page-generator-plugin (2.3.0 instead of 2.2.0)
  Update documentation
  Fix #245 - Add missing Korean translaiton strings
  Update contrast-finder_utf8_es.properties
  Update contrast-finder_utf8_ko.properties
  FIX(form): add lang parameter
  FIX: update changelog
  set version to 0.10.1-SNAPSHOT
  Update contrast-finder_utf8_oc.properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant