Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Check for Omitted fields in compileObjectLiteral #1226

Closed
torch2424 opened this issue Apr 16, 2020 · 0 comments · Fixed by #1229
Closed

Add Check for Omitted fields in compileObjectLiteral #1226

torch2424 opened this issue Apr 16, 2020 · 0 comments · Fixed by #1229

Comments

@torch2424
Copy link
Contributor

Currently, compileObjectLiteral in compiler.ts it is missing to check which fields are not present, and either error if that's non-null and has no initializer, pick the initializer or make it 0.

This was found, and discussed in a Slack discussion. @dcodeIO has context on this as well 😄 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix / Enhancement for Omitted Object Literals torch2424/assemblyscript
1 participant
@torch2424