Fix / Enhancement for Omitted Object Literals

[torch2424]

closes #1226

This fixes the bug where omitted Object literals would just give random memory from the runtime. By introducing an error for class fields that cannot be omitted.

This Enhances Object literals, by allowing the basic AS Types. To be omitted, with default values of zero 😄

TODO: Either we add support for nullable types to default to null and/or add support for making a new instance of a class if the constructor has no parameters in this same PR. Or we can do that work in a seperate PR 😄

cc @dcodeIO @jtenner

P.S. Yay! My first real AS Compiler PR 😄 🎉

Screenshots

[torch2424]

Oops, seems like I am failing the self-compilation tests 🙃

@dcodeIO did you get things self compiling? Should I go back and fix these? Shouldn't be too hard, all I think I really need to do is get rid of the phat arraw function I added 😄 But how do I test the self compiler from my machine? 🤔

[dcodeIO]

Had an initial look and found a couple places that are fine in TS, but a bit tricky in the compiler's "portable AssemblyScript" codebase :)

[dcodeIO]

Regarding self-compilation: Yes, this is indeed part of CI now. The relevant scripts are npm run asbuild to build it, and npm run astest to test it. Unless on top of the vtable branch, the test will not do much and ultimately fail, which is expected, while on top of the vtable branch, it is good enough to output a simple module in text format.

[MaxGraey]

Isn't this relate to #1155 ?

[torch2424]

@dcodeIO Thanks for the quick review! 😄 👍 Gonna start addressing comments in a little bit!

@MaxGraey Ummmm, so I am not too sure? I think it's similar, but a different issue? I'll let @dcodeIO answer that.

[dcodeIO]

It's somewhat related conceptually, yeah. Let's say we call the (default) ctor on object creation, then the ctor may initialize some of these fields, so specifying these is not necessary even though the field is not nullable. However, we are not calling the ctor here even though we should.

Suggesting to do the following to be safe for now: As soon as the class has a constructor, disallow creating it from an object literal. This should avoid any issues, and we can look into actually calling ctors in a later PR.

[jtenner]

It's unfortunate that we aren't like rust, and get to have traits where object literals might make sense.

[torch2424]

@dcodeIO Made all requested changes, and asbuild works on my machine 😄 👍 This is good to go!

[jtenner]

Nice work @torch2424

[dcodeIO]

Thanks! Got a few additional comments, with one RC issue not introduced by this PR, but seems good to fix as well.

[torch2424]

Thanks @jtenner ! 😄 🎉

And made the requested changes @dcodeIO ! 😄

[dcodeIO]

Great! Just a couple nits left, and a suggestion how to support omitting fields that are nullable anyway :)

[torch2424]

@dcodeIO Made requested changes, tests still pass, asbuild still working 😄 👍

[dcodeIO]

Thank you! :)

[torch2424]

Yayyyy! 😄 @dcodeIO Thank you very much for the review. Literally tweeting this out now 😂