Implement grid shader #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenGL and WebGL use the last vertex of each triangle as the provoking vertex, the vertex whose output is used for `@interpolate(flat)` values in the fragment shader's input. All other backends use the first vertex instead.
If this value is less than 1, the grid lines will not render properly.
white-axe
added
enhancement
Speak2Erase
requested changes
Feb 10, 2024
Speak2Erase
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
This pull request implements a shader for drawing grid lines on the map editor and the tilemap.
The lines have a light outline and a dark fill to offer enhanced contrast in a variety of environments. They also scale in thickness with the screen resolution which is important for people with very large screens.
Testing
The shader has been tested to work with Vulkan, WebGL and WebGPU by opening a map and observing that no crashes occur.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknowncargo build --releasetrunk build --release