Proxy Basic auth is broken

[pbostrom]

Hi, I have a proxy server running on regular http, and I'm trying to make a request to an https address. I create a ProxyServer with my host, port, principal and password and set the client's ProxyServer. When I make a http request everything works fine. When I request an https host, the proxy returns 407 Proxy Authentication Required. This works with version 1.8.16. I've just recently been trying to 1.9.31, it seems like this stopped working with 1.9.0.
I have a small testcase I can provide (in Clojure) if that would help. I need to clean it up a little bit first.

[slandelle]

@pbostrom If you can provide a proxy with auth, I can manage.

[pbostrom]

Ok, give me a couple days, I'll get it set up.

[slandelle]

Cool, thanks!

[slandelle]

Note that, for whatever reason, before AHC2, you're supposed to set if the proxy is supposed to be used over HTTP or HTTPS. If you don't, ProxyServer defaults to HTTP and will be ignored for HTTPS.

See https://github.com/AsyncHttpClient/async-http-client/blob/1.9.x/src/main/java/com/ning/http/client/ProxyServer.java#L83

[pbostrom]

Yes, the proxy is set up for HTTP. But any traffic going out from the proxy can be either http or https. This is what the equivalent would look like in curl:
curl --proxy-user username:password --proxy http://myproxy.com:8080 https://www.google.com
I will email you the info for my proxy.

[slandelle]

As I said, ProxyServer API was broken in AHC1, and I couldn't fix it it 1.9. Implementation was broken in 1.8 too, that led you think things were working as expected in 1.8 (connection pooling was broken).

Have a look at the protocols, and please tell me what HTTP and HTTPS have to do with NTLM, KERBEROS and SPNEGO?

So, in AHC1, because of this weird protocol thing, and as ProxyServer only takes one single port, and not two (one for HTTP, one for HTTPS, possibly the same), if you mix HTTP and HTTPS requests, you can't define the proxy at config level. You have to set the proper one on the request.

[pbostrom]

Setting a proxy server with (HTTPS specified) per request does not seem to have any affect. As far as I can tell, AHC 1.9 is not sending the Proxy-Authorization/Proxy-Connection headers with the initial HTTP CONNECT call to the proxy, whereas AHC 1.8 and curl both send the headers. See the attached screenshots:
AHC 1.9

AHC 1.8

Curl

[slandelle]

OK, so now, that's a bug :)
If you can get the proxy set up, I'll gladly fix it.

[pbostrom]

I emailed you the proxy server and credentials to the email on your gh profile.