Make WebSocketUpgradeHandler extensible in a controlled manner. #1446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rotected template methods)
|
I probably won't be able to release before a few days. |
|
@thabach @slandelle Thanks for this, will try to get wasync using this asap. No rush on release yet :) |
|
There is one method setWebSocket, that I was overriding too, so I could grab an instance and use in the extension. Can we add that too? |
|
@slandelle Merci :-) |
|
@seamusmac Go ahead. @jfarcand De rien ;-) |
|
@slandelle please merge #1447 - cheers ! |
slandelle
pushed a commit
that referenced
this pull request
Aug 3, 2017
…rotected template methods) (#1446)
|
@thabach done |
slandelle
pushed a commit
that referenced
this pull request
Aug 3, 2017
…rotected template methods) (#1446)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via protected template methods, make
WebSocketUpgradeHandlerextensible in a controlled manner.