Skip to content

Changed requestTimeout's type to java.time.Duration #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2023
Merged

Changed requestTimeout's type to java.time.Duration #1864

merged 5 commits into from
Apr 23, 2023

Conversation

Asapin
Copy link
Contributor

@Asapin Asapin commented Apr 23, 2023

No description provided.

@hyperxpro
Copy link
Member

Btw, do you wanna investigate flaky tests? They fail randomly and I have to use repetitions to make them pass which is a bad idea.

@Asapin
Copy link
Contributor Author

Asapin commented Apr 23, 2023

I actually had some tests failing today, but they fixed after I re-run them.
I think some of the failing tests tried to connect to google.com with a very small timeout, like 100ms, maybe that was the issue. I don't know the purpose of those tests yet, but maybe they can be fixed if we use Wiremock instead of connecting to google.

I can look into it after I finish converting other timeouts to java.time.Duration

@hyperxpro
Copy link
Member

Also, check logs of this: #1859

@hyperxpro hyperxpro merged commit 0ebfd64 into AsyncHttpClient:main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants