Future-proof HTTPS endpoint identification #2104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netty 4.2 changes the default for hostname verification for TLS clients, so that it is now enabled by default. As a result, clients that rely on the default being _off_ will find themselves unable to disable it. Instead, clients should explicitly configure their desired endpoint identification algorithm in all cases. Since Netty 4.1.112 we also have a convenient method on the `SslContextBuilder` for doing this, so we don't need multiple round-trips through `SSLParameters`. This PR changes the `DefaultSslEngineFactory` to make use of this method, so it always configures the endpoint identification algorithm to match the desired setting of `AsyncHttpClientConfig..isDisableHttpsEndpointIdentificationAlgorithm()`.
hyperxpro
approved these changes
Aug 21, 2025
|
@hyperxpro I don't have the merge button, so feel free to merge any time. |
|
Thanks @chrisvest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netty 4.2 changes the default for hostname verification for TLS clients, so that it is now enabled by default.
As a result, clients that rely on the default being off will find themselves unable to disable it.
Instead, clients should explicitly configure their desired endpoint identification algorithm in all cases.
Since Netty 4.1.112 we also have a convenient method on the
SslContextBuilderfor doing this, so we don't need multiple round-trips throughSSLParameters.This PR changes the
DefaultSslEngineFactoryto make use of this method, so it always configures the endpoint identification algorithm to match the desired setting ofAsyncHttpClientConfig..isDisableHttpsEndpointIdentificationAlgorithm().