Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avviksmeldinger #30

Merged
merged 25 commits into from
Aug 3, 2020
Merged

Avviksmeldinger #30

merged 25 commits into from
Aug 3, 2020

Conversation

rosvik
Copy link
Member

@rosvik rosvik commented Jun 26, 2020

Screenshot 2020-08-03 at 08 45 46

Avviksmeldinger for busstopp og linjer.

  • Styling av meldinger for "stop places" i .../Tile/styles.scss (Se Tollboden og Dronningens gate)
  • Styling av meldinger for "routes" i .../TileRow/styles.scss (Se 11 Welhavens gate, 34 Ekeberg hageby og 81 Fornebu)
  • Data hentes fra situations i Entur APIet, src/service.ts.
  • Støtte for flere meldinger pr. stop place og route (Se 34 Ekeberg hageby). Dette er grunnen til endringene i src/utils.tsx.
  • src/logic/getDisruptionMessages.ts: Hvis alle routes som går fra en stop place har samme feilmelding, vises dette som en feil på hele stoppet, ikke for hver enkelt rad.
  • Ikoner for feilmeldiner på enkeltavganger har blitt fjernet .../TileRow/index.tsx.
  • Det er planlagt å fjerne gulfargen på sanntidsavganger, siden det kan være litt forvirrende at det er samme farge som feilmeldinger.

Siden branchen startet med å laste avviksmeldinger gjennom GTSF-RT og protobuf, er her en hel del commits som blir overskrevet senere.

Closes #29

@rosvik rosvik added the feature New feature or request label Jun 26, 2020
@rosvik rosvik self-assigned this Jun 26, 2020
@rosvik rosvik marked this pull request as ready for review August 3, 2020 07:07
Copy link

@rinoandrejohnsen-atb rinoandrejohnsen-atb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lenge siden jeg har lest React, men ut i fra hva jeg kunne dra ut, så ser det bra ut 👍

Copy link

@torfjor torfjor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rosvik rosvik merged commit 501c47a into atb/main Aug 3, 2020
@rosvik rosvik deleted the atb/29-avviksmeldinger branch August 5, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avviksmeldinger
3 participants