Feature: refactor pages and labels #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implements AtlassianPS#15
implements AtlassianPS#23
* renamed function * created custom object type for the set "Page+Labels" implements AtlassianPS#23
… `label` is empty implements AtlassianPS#23
implements AtlassianPS#23
* better handling of pipe input * more tests for ContentLableSet objects * Get-WikiLabel takes array of pages as input * all functions return ContentLableSet implements AtlassianPS#23
Must be alphabetical to match the check in ConfluencePS.Base.Tests.ps1
brianbunke
requested changes
Apr 17, 2017
There was a problem hiding this comment.
Also changed this block in the integration tests for Add-WikiLabel
It 'label matches the specified value' {
$NewLabel1.Labels.Name | Should BeExactly $Label1
$NewLabel2.Labels.Name -contains $Label2 | Should Be $true
$NewLabel3.Labels.Name -match $PartialLabel | Should Be ($Label1 + $Label2)
}| ) | ||
|
|
||
| DynamicParam { | ||
| if (!($Page)) { | ||
| $paramDictionary["PageID"] | Out-String | Write-Host |
There was a problem hiding this comment.
This block is triggering and causing the test errors on Get-WikiPage/Add-WikiLabel right now
There was a problem hiding this comment.
removed with 48bdb98
I was experimenting with the parameters and forgot to remove this debug code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements:
New-WikiLabeltoAdd-WikiLabelStructure of Label functions #23Set-WikiLabelStructure of Label functions #23Remove-WikiLabelto remove all labels of page Structure of Label functions #23ContentLabelSetas output of all Label functions Structure of Label functions #23