Craft Skill and other related things #595

AquariusPower · 2020-04-25T00:49:02Z

It has also a fix for crafting something that breaks and has no config at .dat files.
(cherry pick from #587)

update from main

(ready) New monsters (Attnam#349)

update from main

(ready) bug fix for show items under (Attnam#369)

(ready) Fantasy name generator (Attnam#363)

update from main

…aster

update from main

updating

update

udpating

update

update from main

update form main

upd

Merge master

Update master

…ent framework;

AquariusPower · 2020-05-03T21:19:08Z

this should receive an update I didnt mange yet to bring from #587
about a chance of gaining craft skill every craft turn on long lasting crafting tasks.

tailoring workbench and related graphics other craft related improvements (cherry picking got overly complicated and time consuming so I just copied the whole related files (or merged parts of them using `Meld`) from the other branch)

red-kangaroo · 2020-05-30T13:28:18Z

@AquariusPower One thing I noticed in #596 : When splitting rocks with no appropriate tool, the game tells you that you need a cutting tool, but you actually need a hammer.

red-kangaroo · 2020-05-30T13:48:29Z

Main/Source/cmdcraft.cpp

+  }
+
+  virtual void fillInfo(){
+    init("build","a tailoring workbench");


Maybe change normal workbench to "crafting workbench" then, to make it clear in the F menu how are the two workbenches different?

may be "smithing bench" but I read it is more related to metal work, "crafting workbench" is more generic indeed and may be clearer

Yeah, "smithing" is metal work and we already have an anvil for that. :)

Change made. :)

red-kangaroo · 2020-05-30T14:17:25Z

Could we get reorganized skill overview? Right now, it says "Your experience in weapon categories"/"battle bonus", and then lists crafting. :)

There's crafting skill in the @ menu, and then crafting proficiency in F menu. Does crafting skill increase your crafting proficiency?

When crafting from ingots, they are instantly transformed to lumps if you cancel the crafting after selecting materials but before beginning the crafting action. They should only get lumped if you start crafting and then fail/stop.

What if you could craft any furniture, even if they don't do anything? Maybe the player wants to build a small house with some beds and an oven.

Spider silk from webs is a great touch. :)

AquariusPower · 2020-05-30T21:29:09Z

@AquariusPower One thing I noticed in #596 : When splitting rocks with no appropriate tool, the game tells you that you need a cutting tool, but you actually need a hammer.

if I am not wrong, I initially thought and coded it like: to split a rock you would need a dagger and a hammer, so that you would aim the dagger on the rock and hit the hammer on the dagger's hilt. But the warn/user/help message may be imprecise!

AquariusPower · 2020-05-30T21:58:35Z

Could we get reorganized skill overview? Right now, it says "Your experience in weapon categories"/"battle bonus", and then lists crafting. :)

The skill progress system was already implemented as weapon skills, it just took me some more time than usual to realize that xD

There's crafting skill in the @ menu, and then crafting proficiency in F menu. Does crafting skill increase your crafting proficiency?

in the F menu (that is a good and innocent menu, just meaning craFting xD), so it works like this:
You have the craft skill, that increases with each related action.
You have a crafting bonus based on your stats (mainly dexterity).
On that special menu, the crafting value shown is: CraftSkill+CraftBonus
Btw, craft bonus now begins in 0 if you have all stats in 10, what is an incentive to develop the craft skill. (I think there is a limit tho, the final value is never less than 1)

When crafting from ingots, they are instantly transformed to lumps if you cancel the crafting after selecting materials but before beginning the crafting action. They should only get lumped if you start crafting and then fail/stop.

Agreed! and the way it is now it is quite annoying/unfair...
But to let it work properly, it would require a quite more complex code (I guess),
or... I just thought it... we could implement an "UNDO" code, that would join the lump back into the ingot if the crafting action doesnt really begin.
Cutting the ingot (or any other crafting basic item) and creating the lump is a preparation to the crafting process but it should be undone if that isnt started!

Cool, I think an UndoCraftingPreparation() could be a good workaround!
May be, the new cut ingot and the new lump could be just deleted and the old one could be just restored, I dont know yet the best way to implement it tho.

What if you could craft any furniture, even if they don't do anything? Maybe the player wants to build a small house with some beds and an oven.

Nice! it would open a menu listing them all, may be the useful ones on the top.
The problem is the volume of materials required to build them. May be all "non useful" could have a default small value, may be 2000cm3,
or we could add a property on the .dat file related to furniture, something like: ToCraftVolumeRequired = 2000, that being default, but later we could specify each, and it would be better.

Spider silk from webs is a great touch. :)

Used in tailoring as sewing material, but we can craft gloves etc from it too, yep it is fun.
After that I avoid killing spiders to let them create webs I can collect. Btw, in my house irl, I get all these inoffensive spiders and put them on the plants to help fighting insects, inoffensive spiders are very cool! xD

… the other branch/PR

- polymorphed also affects craft skill; - fixed missing tailoring savegame data; - fixed remaining turns calculation to work as originally intended; - reworked fumble algorithm, generally it feels much better/faster (may be easier too) to use crafting now;

ryfactor · 2021-09-14T03:48:05Z

It compiles and runs on Windows. I haven't tested anything but it seems to work OK.
Can we merge this yet?

ryfactor · 2021-10-22T02:30:53Z

I would like to merge this next. I think it is ok @red-kangaroo ?

red-kangaroo

Several tiny gripes I had fixed, otherwise seems good. :)

red-kangaroo · 2021-10-22T07:09:09Z

Main/Source/game.cpp

@@ -382,7 +382,12 @@ void game::InitScript()

 truth game::IsQuestItem(item* it) //dont protect against null item* it may be a problem outside here.
 {
-  return it->IsQuestItem();
+  return it->IsQuestItem() //TODO this call should suffice instead of this very function


These extra checks are redundant.

…aft Skill PR #595) (#596) * change light emitation (to less) based on object volume * fixed minimum emitation and workaround/fix for other related bugs still highly depends on crafting updated code tho * light emit based on volume, reworked calc.

AquariusPower and others added 30 commits May 24, 2018 16:22

Merge pull request #24 from Attnam/master

15d64ae

update from main

Merge pull request #25 from Attnam/master

99ef7d6

(ready) New monsters (Attnam#349)

Merge pull request #26 from Attnam/master

af8c444

update from main

Merge pull request #27 from Attnam/master

9979cf8

(ready) bug fix for show items under (Attnam#369)

Merge pull request #28 from Attnam/master

8714ec6

(ready) Fantasy name generator (Attnam#363)

Merge pull request #29 from Attnam/master

47044b9

update from main

Merge branch 'master' of https://github.com/Attnam/ivan into Attnam-m…

b4be00e

…aster

Merge branch 'master' of https://github.com/Attnam/ivan into Attnam-m…

a5387b8

…aster

Merge pull request #30 from Attnam/master

9f2cf80

update from main

Merge pull request #31 from Attnam/master

6d71776

update from main

Merge pull request #32 from Attnam/master

0f7bbaa

update from main

Merge pull request #33 from Attnam/master

932103d

update from main

Merge pull request #34 from Attnam/master

d5bfecc

update from main

Merge pull request #35 from Attnam/master

d028bf9

update from main

Merge pull request #37 from Attnam/master

1812c10

update from main

Merge pull request #38 from Attnam/master

cf1dc8e

update from main

Merge pull request #39 from Attnam/master

91dd7fd

updating

Merge pull request #40 from Attnam/master

11f489a

update

Merge pull request #41 from Attnam/master

10b7dab

udpating

Merge pull request #42 from Attnam/master

5e97b45

update

Merge pull request #43 from Attnam/master

2bcac17

update from main

Merge pull request #44 from Attnam/master

2adf952

update from main

Merge pull request #45 from Attnam/master

2ea63f2

update form main

Merge pull request #46 from Attnam/master

e9ef42d

upd

Merge pull request #48 from Attnam/master

720ec65

upd

Merge pull request #49 from Attnam/master

57200e5

upd

Merge remote-tracking branch 'upstream/master'

7aa508c

Merge remote-tracking branch 'upstream/master'

fb047bf

Merge master

Merge remote-tracking branch 'upstream/master'

2e947f0

Update master

Merge remote-tracking branch 'upstream/master'

bd0f631

WIP-craft: added crafting skill, using existing weapon skill advancem…

6eaaf8a

…ent framework;

AquariusPower mentioned this pull request Apr 25, 2020

(See the other PRs first!) This is the merge of all my other PRs + some fixes and adjustments. #587

Open

AquariusPower added 3 commits May 5, 2020 17:53

craft: copied missing olterra cfg for tailoring bench;

e66f688

fix game::IsQuestItem()

3e7ea92

AquariusPower mentioned this pull request May 24, 2020

Multiple quest-critical items can be dismantled via the crafting system. #603

Closed

ryfactor requested a review from red-kangaroo May 28, 2020 22:10

red-kangaroo reviewed May 30, 2020

View reviewed changes

AquariusPower mentioned this pull request May 31, 2020

Item light emitation based on volume (experimental. And depends on Craft Skill PR #595) #596

Merged

AquariusPower added 6 commits June 1, 2020 18:45

fixes to prevent bugs related to the light based on volume's code, of…

b3921ab

… the other branch/PR

Merge branch 'master' into CraftSkill2

4721613

fix bug craft split sol stone

ac4ad6c

crafting: undo remains if user cancel the action;

4401eba

fixing code, went too much from main branch...

47f265a

craft:

2cbc9d9

- polymorphed also affects craft skill; - fixed missing tailoring savegame data; - fixed remaining turns calculation to work as originally intended; - reworked fumble algorithm, generally it feels much better/faster (may be easier too) to use crafting now;

AquariusPower changed the title ~~Craft Skill~~ Craft Skill and other related things Jun 15, 2020

Merge branch 'master' into CraftSkill2

d548f52

Merge remote-tracking branch 'upstream/master'

48579bb

red-kangaroo added 2 commits October 22, 2021 09:20

Merge remote-tracking branch 'origin/master' into CraftSkill

a14564d

Minor fixes

2af0bf1

red-kangaroo approved these changes Oct 22, 2021

View reviewed changes

ryfactor merged commit a3e5865 into Attnam:master Oct 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Craft Skill and other related things #595

Craft Skill and other related things #595

AquariusPower commented Apr 25, 2020 •

edited

Loading

AquariusPower commented May 3, 2020

red-kangaroo commented May 30, 2020

red-kangaroo May 30, 2020

AquariusPower May 30, 2020

red-kangaroo Jun 3, 2020

red-kangaroo Oct 22, 2021

red-kangaroo commented May 30, 2020

AquariusPower commented May 30, 2020

AquariusPower commented May 30, 2020 •

edited

Loading

ryfactor commented Sep 14, 2021

ryfactor commented Oct 22, 2021

red-kangaroo left a comment

red-kangaroo Oct 22, 2021

Craft Skill and other related things #595

Craft Skill and other related things #595

Conversation

AquariusPower commented Apr 25, 2020 • edited Loading

AquariusPower commented May 3, 2020

red-kangaroo commented May 30, 2020

red-kangaroo May 30, 2020

Choose a reason for hiding this comment

AquariusPower May 30, 2020

Choose a reason for hiding this comment

red-kangaroo Jun 3, 2020

Choose a reason for hiding this comment

red-kangaroo Oct 22, 2021

Choose a reason for hiding this comment

red-kangaroo commented May 30, 2020

AquariusPower commented May 30, 2020

AquariusPower commented May 30, 2020 • edited Loading

ryfactor commented Sep 14, 2021

ryfactor commented Oct 22, 2021

red-kangaroo left a comment

Choose a reason for hiding this comment

red-kangaroo Oct 22, 2021

Choose a reason for hiding this comment

AquariusPower commented Apr 25, 2020 •

edited

Loading

AquariusPower commented May 30, 2020 •

edited

Loading