[C-838] Fix desktop update banner flow

[raymondjacobson]

Description

Redid this PR from scratch. @sliptype / @Kyle-Shanks could use extra scrutiny here.

I think there are still two issues with the desktop update flow that prevent "web app" updates from working:

1. we trigger an electron banner update and a web banner update at the same time
2. we are using some state variable showWebUpdate to determine whether to show the web update banner, and i'm pretty sure that never gets set to true (it's showWebUpdateBanner), so #1 isn't actually an issue we observe

These changes are set up in a way such though that when we download the electron changes in the background, on restarting, the user will still get the full electron update.

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Will test after merge to main via the staging desktop app

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

Feature Flags

Are all new features properly feature flagged? Describe added feature flags.

[audius-infra]

Preview this change https://demo.audius.co/rj-c-838

[sliptype]

Kinda confused on how this is working. Doesn't this conditional conflict with the one we have in the handler? https://github.com/AudiusProject/audius-client/blob/main/packages/web/src/pages/App.js#L287

Are we losing the forced major version updates with this?

[raymondjacobson]

Kinda confused on how this is working. Doesn't this conditional conflict with the one we have in the handler? https://github.com/AudiusProject/audius-client/blob/main/packages/web/src/pages/App.js#L287

Are we losing the forced major version updates with this?

Based on the code in this change--

If we are running 1.0.1 and 1.0.2 exists, electron will recognize an update, but because major and minor are the same, will not send an updateAvailable message to web. When quitting & restarting the app, the update will be installed. The separate webUpdateAvailable code will run though and trigger a patch version refresh update.

If we are running 1.0.1 and 1.1.0 exists, electron will recognize an update, and because minor version is different, it will send an updateAvailable message to web. Web will then see the updateAvailable and see semver.minor(currentVersion) < semver.minor(version) and pop up the message that forces an update.

[sliptype]

Kinda confused on how this is working. Doesn't this conditional conflict with the one we have in the handler? https://github.com/AudiusProject/audius-client/blob/main/packages/web/src/pages/App.js#L287
Are we losing the forced major version updates with this?

Based on the code in this change--

If we are running 1.0.1 and 1.0.2 exists, electron will recognize an update, but because major and minor are the same, will not send an updateAvailable message to web. When quitting & restarting the app, the update will be installed. The separate webUpdateAvailable code will run though and trigger a patch version refresh update.

If we are running 1.0.1 and 1.1.0 exists, electron will recognize an update, and because minor version is different, it will send an updateAvailable message to web. Web will then see the updateAvailable and see semver.minor(currentVersion) < semver.minor(version) and pop up the message that forces an update.

But doesn't the handler in App.tsx already only show the banner if it's a minor or major version update? Won't auto-updater still download the patch version in the background anyway? Maybe I'm still not quite understanding, lets chat in our 1 on 1

[raymondjacobson]

Kinda confused on how this is working. Doesn't this conditional conflict with the one we have in the handler? https://github.com/AudiusProject/audius-client/blob/main/packages/web/src/pages/App.js#L287
Are we losing the forced major version updates with this?

Based on the code in this change--
If we are running 1.0.1 and 1.0.2 exists, electron will recognize an update, but because major and minor are the same, will not send an updateAvailable message to web. When quitting & restarting the app, the update will be installed. The separate webUpdateAvailable code will run though and trigger a patch version refresh update.
If we are running 1.0.1 and 1.1.0 exists, electron will recognize an update, and because minor version is different, it will send an updateAvailable message to web. Web will then see the updateAvailable and see semver.minor(currentVersion) < semver.minor(version) and pop up the message that forces an update.

But doesn't the handler in App.tsx already only show the banner if it's a minor or major version update? Won't auto-updater still download the patch version in the background anyway? Maybe I'm still not quite understanding, lets chat in our 1 on 1

Redid this PR

[audius-infra]

Preview this change https://demo.audius.co/rj-c-838

[sliptype]

This mostly makes sense but we are still setting showWebUpdate to true:

audius-client/packages/web/src/pages/App.js

Line 283 in 39fb657

this.setState({ showWebUpdate: true })

[raymondjacobson]

This mostly makes sense but we are still setting showWebUpdate to true:

audius-client/packages/web/src/pages/App.js

Line 283 in 39fb657

this.setState({ showWebUpdate: true })

Yeah great catch. That's how it was working before

[audius-infra]

Preview this change https://demo.audius.co/rj-c-838

[amendelsohn]

Is this no longer necessary because the app is going to restart on update and not show the banner after?

[raymondjacobson]

Basically there are two flows for upgrading desktop:

• An update to entire electron app (you need a new chromium basically)
• An update to just the static JS for the SPA
  KJ added the latter recently, which lets us basically not worry about showing a banner for the former and letting auto update on quit take care of that behind the scenes. There's still banner that shows that will get dismissed in the below method (acceptWebUpdate) but that's for the latter SPA refresh