[C-1023] [C-1039] Sync account entropy from webview and improve splashscreen #1938

sliptype · 2022-09-16T17:11:19Z

Description

Wait to set up backend until we either have account entropy or we've checked the webview for it in localStorage

This is written in a way where we can rip out WebAppAccountSync easily in the future
Fix sign out by setting initial account status to IDLE
Improve splash screen by layering it on top of the other screens and rendering null as soon as the animation is complete. The animation is triggered once the account status is known

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Tested e2e by running the old webview version of the app locally, signing in, then upgrading to the new version and confirming that I was still signed in

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

Feature Flags

Are all new features properly feature flagged? Describe added feature flags.

gitguardian · 2022-09-16T17:11:54Z

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
2858199	Generic High Entropy Secret	`1ceb449`	packages/mobile/.env.dev.tmpl	View secret
2858198	Generic High Entropy Secret	`1ceb449`	packages/mobile/.env.prod.tmpl	View secret
2858199	Generic High Entropy Secret	`1ceb449`	packages/mobile/.env.stage.tmpl	View secret
2858198	Generic High Entropy Secret	`d7df88d`	packages/web/.env/.env.prod	View secret
2858199	Generic High Entropy Secret	`d7df88d`	packages/web/.env/.env.stage	View secret
2858198	Generic High Entropy Secret	`cbaba35`	packages/web/.env/.env.prod	View secret
2858199	Generic High Entropy Secret	`cbaba35`	packages/web/.env/.env.stage	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

dylanjeffers

Wow this is awesome work!

[3394a06] Fix infinite lineup fetch (#1940) Sebastian Klingler [19381a3] [C-296] Persist stack history across bottom tabs (#1939) Dylan Jeffers [6705cb5] [C-1118] Send tip -> send audio (#1937) nicoback2 [9c63ab7] [C-1023] [C-1039] Sync account entropy from webview and improve splashscreen (#1938) Sebastian Klingler [e3d9cc4] [C-1064] Show "You're Offline" component on mobile (#1936) Andrew Mendelsohn [16a8b96] [C-1113] Improve native render performance (#1935) Dylan Jeffers [7f4ede3] Fix broken signup on web (#1934) Michael Piazza [2373ae0] fix rewards claim (#1933) nicoback2 [54dcd64] [C-1107] Fix push to sign in when identity is down (#1931) Raymond Jacobson [43222ee] [C-1091] Improve selector performance (#1932) Dylan Jeffers [eee12c7] Add request pagination for favorites for the new table (#1850) Kyle Shanks [5d43c12] upgrade sdk (#1929) nicoback2 [2fd28e4] [Reloaded] No more useDispatchWeb, messages C-1089 (#1927) nicoback2 [6fc8709] Merge pull request #1928 from AudiusProject/jn-exporter-default Johannes Naylor [24d9d3b] [C-838] Fix desktop update banner flow (#1719) Raymond Jacobson [aace104] remove console exporter and change default to undefined Johannes Naylor [81e9a4d] Detach mobile reachability state from non existent webview C-938 (#1913) nicoback2 [9c6c067] Merge pull request #1878 from AudiusProject/jn-con-385 Johannes Naylor [5f335bb] Update mobile readme install instructions (#1926) Dylan Jeffers [8469883] [C-907] Fix react native push notifications (#1922) Raymond Jacobson [543b013] Fix pull to refresh (#1925) Sebastian Klingler [370088e] Fix issue with using `accountUser` handle (#1924) Sebastian Klingler [5a496fa] fix more by artist lineup (#1921) nicoback2 [cab5181] downgrade node Johannes Naylor [5602eab] pin deps Johannes Naylor [7a95b3f] Fix infinite 404 (#1920) Sebastian Klingler [8cdc9b9] [C-1060] Fix /check page (#1919) Raymond Jacobson [375c5dd] [PAY-578] Fade in socials on mobile user screen (#1905) Reed [2b1cc7f] Wait for libs before signing data (#1918) Sebastian Klingler [d06e2c1] update env var Johannes Naylor [5efd985] [C-1031] Improve profile expand section touch target (#1911) Dylan Jeffers [f327636] [C-1053] Fix ios status color in dark/light modes (#1917) Dylan Jeffers [7a167b6] [C-1050] Fix profile search crash (#1916) Dylan Jeffers [32b8c82] [C-1057] Fix blank edit-profile screen (#1915) Dylan Jeffers [406e6c0] no more useselector web (#1914) nicoback2 [98ed3f6] [C-1029] Fix pull-to-refresh (#1912) Dylan Jeffers [7582351] Migrate useGetFirstOrTopSupporter (#1910) Sebastian Klingler [b9e4e41] add env vars Johannes Naylor [44060c1] remove telemetry Johannes Naylor [53483ef] remove telemetry Johannes Naylor [ae57626] remove telemetry Johannes Naylor [0515567] more telemetry Johannes Naylor [2da8c47] install Johannes Naylor [379af75] Merge branch 'main' into jn-con-385 merge main Johannes Naylor [d0deea6] changing things around Johannes Naylor [22288b1] [C-1012] Remove web build from mobile build (#1907) Raymond Jacobson [8572ee3] [C-1027] Improve bottom-bar perf (#1909) Dylan Jeffers [a41d536] the goods Johannes Naylor [128aa9b] move the instrumentation to the audiusBackend Johannes Naylor [a27c976] Fix profile clearing (#1908) Dylan Jeffers [75e6eec] Remove react-nil and NATIVE_NAVIGATION (#1906) Dylan Jeffers [ebbb561] Update social features to use entity manager (#1853) Isaac Solo [99952d1] [C-990] Nativefy oauth (#1885) Raymond Jacobson [c149204] Fix failing CI init (#1904) Sebastian Klingler [d436adb] [C-1009] Fix misaligned social icons (#1901) Dylan Jeffers [d21d5d4] [C-1020] Remove web pushes (#1902) Dylan Jeffers [600f673] [C-711] Change useSize to useMeasure in ProfileBio (#1903) Reed [497da98] stuff Johannes Naylor [7f4a144] try a bunch of things Johannes Naylor [66995fa] Clean up some more instances of useSelectorWeb/useDispatchWeb (#1900) Sebastian Klingler [3383135] Nativefy remixes screen (#1887) nicoback2 [8b0d1e5] Fix edit profile screen (#1899) Sebastian Klingler [fb3c189] [C-996] Remove NATIVE_MOBILE references (#1895) Dylan Jeffers [bb0a03e] Fix lineup state persisting across profile screens sliptype [5150a58] [PAY-626] Change playlist+tip challenges copy and emoji (#1897) Reed [e816c64] [PAY-625] Playlist challenge optimistic claiming (#1891) Reed [f3c02b6] [C-892] Fix multiple menus open at once (#1889) Andrew Mendelsohn [192c669] run setupTracing Johannes Naylor [00f3951] add tracer Johannes Naylor

raymondjacobson and others added 7 commits September 14, 2022 00:20

[C-1012] Recover web app account in native

1ceb449

Fix issue with sign out

1289b36

Merge branch 'sk-c-1039-splash-screen' into rj-c-1023

d7df88d

Wait for entropy to setup backend

0c2637e

Check if reachability is already true

ab9d52b

Improve splash screen transition

acea652

Remove log

406b6e4

sliptype requested review from raymondjacobson and dylanjeffers September 16, 2022 17:11

pull-request-size bot added the size/L label Sep 16, 2022

dylanjeffers approved these changes Sep 16, 2022

View reviewed changes

Merge branch 'main' into sk-c-1039-splash-screen

cbaba35

sliptype merged commit 9c63ab7 into main Sep 16, 2022

sliptype deleted the sk-c-1039-splash-screen branch September 16, 2022 19:59

sliptype mentioned this pull request Sep 16, 2022

[C-1012] Recover web app account in native #1923

Closed

AudiusProject deleted a comment from linear bot Sep 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[C-1023] [C-1039] Sync account entropy from webview and improve splashscreen #1938

[C-1023] [C-1039] Sync account entropy from webview and improve splashscreen #1938

sliptype commented Sep 16, 2022

gitguardian bot commented Sep 16, 2022 •

edited

dylanjeffers left a comment

[C-1023] [C-1039] Sync account entropy from webview and improve splashscreen #1938

[C-1023] [C-1039] Sync account entropy from webview and improve splashscreen #1938

Conversation

sliptype commented Sep 16, 2022

Description

Dragons

How Has This Been Tested?

How will this change be monitored?

Feature Flags

gitguardian bot commented Sep 16, 2022 • edited

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

dylanjeffers left a comment

Choose a reason for hiding this comment

gitguardian bot commented Sep 16, 2022 •

edited