Update sqlalchemy-utils to fix create_database issues #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piazzatron
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sqlalchemy-utils recently updated with a number of fixes to support SQL Alchemy 1.4: kvesteri/sqlalchemy-utils#506
Notably we do not use SQL Alchemy 1.4, but some of the fixes here look promising for a bug we've been experiencing in CI (
CREATE DATABASE cannot run inside a transaction block), namely the changes to thecreate_databaseto remove theAUTOCOMMITas that was discussed in a thread to be a potential cause. The solution in that thread was to include theAUTOCOMMITin the engine creation which required a fork of sqlalchemy-utils or rolling our owncreate_database, but we want to see if this update fixes it first.Tests
Ran all existing tests.
How will this change be monitored?