Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EnumSetProperty #383

Closed
ljacqu opened this issue Sep 15, 2023 · 2 comments
Closed

Add EnumSetProperty #383

ljacqu opened this issue Sep 15, 2023 · 2 comments
Assignees
Labels
good-first-issue Want to contribute? This label marks well-defined, [relatively] straightforward issues
Milestone

Comments

@ljacqu
Copy link
Member

ljacqu commented Sep 15, 2023

Introduce an EnumSetProperty that goes along with EnumSetPropertyType.

To do

  • Create a class EnumSetProperty in the same package as SetProperty
    • It should extend SetProperty and use the constructor that takes PropertyType<Set<E>> as argument
    • Call the constructor with the already existing EnumSetPropertyType
    • Expected constuctors on EnumSetProperty are EnumSetProperty(String path, Class<E> enumClass, E... defaultValue) and EnumSetProperty(String path, Class<E> enumClass, EnumSet<E> defaultValue)
  • Add tests (see other test classes, like LowercaseStringSetPropertyTest)
@ljacqu ljacqu added this to the 2.1.0 milestone Apr 28, 2024
@ljacqu ljacqu added the good-first-issue Want to contribute? This label marks well-defined, [relatively] straightforward issues label Apr 28, 2024
@lengeligor
Copy link
Contributor

Hi @ljacqu can you assigne me issue? I would like to contribute

@ljacqu
Copy link
Member Author

ljacqu commented Oct 2, 2024

Hi @lengeligor, absolutely, thanks for picking this up!

ljacqu pushed a commit that referenced this issue Oct 8, 2024
* 383 -> add EnumSetProperty.java

* 383 -> code climate edits

* 383 -> edit by review comments

* 383 -> edit by review comments

* 383 -> Fix constructor call
@ljacqu ljacqu modified the milestones: 2.1.0, 2.0.0 Oct 8, 2024
@ljacqu ljacqu closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Want to contribute? This label marks well-defined, [relatively] straightforward issues
Development

No branches or pull requests

2 participants