Fix for secure storage in Chrome

[mtravnicek]

This is followup to #384, sorry for taking too long... i hope/dont know if it is still relevant with latest browser updates. I was trying this about an half year ago, but my version of extension is 5.3.2

In Chrome there is (and should be still) problem with storing anything in local storage,
there is "transaction log" 000003.log with everything what was written and even overwritten/deleted! It is described in detail here: https://blog.bitwarden.com/chrome-extension-version-1-24-security-fix-1ce700aeccf6

So issue is when enabling encryption in your extension if there were some unencrypted entries before, it will stay in the file! Chrome may cleanup this file some time in future or fix this or who knows... Workaround fix is when saving delete everything that was stored before, all these values are somehow in memory already so nothing is lost only old is erased... I dont know if this is feature of your code or Chrome storage api, but please refactor so it is clear what methods do....

I somehow hacked it but this JS is hacky on its own, i dont even know what it is exactly doing as of now. Try for yourself and refactor! PS I am not sure if my approach does not erase the whole user storage, but it should be limited to this extension as of storageAPI.
There is much duplicity and crossing of concerns in what methods do like set/remove.... add/update/set there is two classes in one file and methods with 100 lines are not good.
While dissecting EntryStorage and BrowserStorage to distinct classess/files try to introduce for example polymorphic separation (2 classes with common interface) for "local" storage and "sync" storage and get rid of those if statements on every other line...

https://refactoring.guru/replace-conditional-with-polymorphism
Also relevant is SingleResponsiblity, so for example BrowserStorage getStorageLocation should not check wheter browser is Edge or whatever... that belongs to some other (extracted) function

Here:storage.js

[mymindstorm]

Thanks for this. Was able to confirm this with Chromium 78.0.3904.108. Calling chrome.storage.xxx.clear seems to remove the logs.

It looks like you tried to edit the compiled typescript. models/storage.ts just contains utility classes (not very OOP in the first place). You probably wanted this:

Authenticator/src/store/Accounts.ts

Lines 173 to 192 in b9511ba

	changePassphrase: async (
	state: ActionContext<AccountsState, {}>,
	password: string
	) => {
	await EntryStorage.import(
	new Encryption(password),
	await EntryStorage.getExport(state.state.encryption as Encryption)
	);
	state.state.encryption.updateEncryptionPassword(password);
	chrome.runtime.sendMessage({
	action: "cachePassphrase",
	value: password
	});
	await state.dispatch("updateEntries");
	// remove cached passphrase in old version
	localStorage.removeItem("encodedPhrase");
	},