Port to edge #175
Merged
Port to edge #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's something wrong with me
|
Interesting. Does Edge support |
|
There is a tool called the Edge Extension Toolkit that makes those ABIBridge scripts. I think those provide support for the chrome namespace. |
|
It's confirmed now. https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/18438862 |
|
Ok so DO NOT under any circumstances try to run the build script again until you fully uninstall the extension from edge or the folder thing happens. |
|
That's everything! I've tested all of it, so if the code looks fine we can merge this. |
Sneezry
approved these changes
Jul 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought edge was ok before, but now I loathe it.
Sideloading unpacked extensions (not sideloading an appx package) will cause it to have weird issues that don't happen when loaded via
Add-AppxPackage. UsingAdd-AppxPackageis great except for that fact that storage.sync stops working altogether.That type of issue is manageable at least, unlike this lovely utility.
Add-AppxPackageat first glance is a great utility. Sadly, it turs out thatAdd-AppxPackageis stupid. I can't use a packed extension without signing it (understandable). But if you aren't careful when loading an unpacked appx this happens:Lo and behold, I need permission from myself to delete this folder. I'm probabbly going to have to go to safe mode just to delete a folder. The constant crashing when using debugging tools isn't really helping either.
In terms of actual problems, the port works for the most part. You can't download a backup, it's a known issue. Links to extension pages don't work either (E.g. "Import Backup"), still have to experiment with that. All I could find were old issues either resolved or marked as not reproducible. I've made an issue in the public bug tracker for now. Everything else seems to work perfectly (except dropbox, identity isn't supported).
You can use
installEdgeorpackageEdgeto install it. All the scripts I added work with Cygwin (C: is /cygdrive/c).packageEdgeuses the makeappx.exe that the App Certification Kit installs, so yours might be in a different location and cause the packaging script to fail.