manual entry improvements (#306) #357
Conversation
|
zh_CN/message.json should be updated as well. Maybe we should move zh_CN back to crowdin |
|
zh-cn is on crowdin now |
| const entry = new OTPEntry({ | ||
| if (type === OTPType.hhex || type === OTPType.hotp) { | ||
| this.newAccount.period = NaN; |
There was a problem hiding this comment.
NaN may not be a good default value here. If period is not available for specific types, null or undefined is a better option.
There was a problem hiding this comment.
this.newAccount.period is typed as a number and it wouldn't let me set it as null. NaN evaluates to false so it will just treat it as if period was set to null. Is there a good reason not to use NaN?
There was a problem hiding this comment.
NaN's meaning is Not a Number. When you regard something not a number as a number (such as using Number function), its value will be set to NaN. Here, hhex or hotp doesn't has period property, but not has period of which value is not a number. null is all zero in bits in memory, which means nothing, or doesn't exist. We can change type of this.newAccount.period to number | null.
mymindstorm
force-pushed
the
manual-improve
branch
from
4100ce2 to
16f20c8
Compare
2 participants
No description provided.