Skip to content

Conversation

mymindstorm
Copy link
Member

No description provided.

Can't manipulate cookie from background script
@mymindstorm mymindstorm requested a review from Sneezry July 13, 2019 03:50
@Sneezry
Copy link
Member

Sneezry commented Jul 31, 2019

Removing "persistent": false doesn't make sense.

Cookies itself has expires feature, and we can use this feature to handle auto lock.

This reverts commit 9c50555.
@mymindstorm

This comment has been minimized.

@mymindstorm

This comment has been minimized.

@mymindstorm
Copy link
Member Author

Basically:

Problem 1: Can't access cookie from background script

Solution: Move cookie to background script

Problem 2: Timeout in background doesn't work (likely due to content script getting unloaded)

Solution: Make background script persistent

After moving everything to background and then making it un-persistent, it becomes redundant to store the passphrase in a cookie so I removed it.

@Sneezry
Copy link
Member

Sneezry commented Aug 8, 2019

I think we needn't move cookie to background. When the user change auto lock settings in popup page, script runs in popup page can change the cookie. And when it's time cookie expires, browser should remove the cookie, and we do not need to do the removal in our code.

@mymindstorm
Copy link
Member Author

How about this?

@erickufrin-okta

This comment has been minimized.

@mymindstorm

This comment has been minimized.

@mymindstorm mymindstorm merged commit 59b8950 into dev Aug 18, 2019
@mymindstorm mymindstorm deleted the autolock branch August 18, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants