-
Notifications
You must be signed in to change notification settings - Fork 983
Autolock #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autolock #359
Conversation
Can't manipulate cookie from background script
Removing Cookies itself has expires feature, and we can use this feature to handle auto lock. |
This reverts commit 9c50555.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Basically: Problem 1: Can't access cookie from background script Solution: Move cookie to background script Problem 2: Timeout in background doesn't work (likely due to content script getting unloaded) Solution: Make background script persistent After moving everything to background and then making it un-persistent, it becomes redundant to store the passphrase in a cookie so I removed it. |
I think we needn't move cookie to background. When the user change auto lock settings in popup page, script runs in popup page can change the cookie. And when it's time cookie expires, browser should remove the cookie, and we do not need to do the removal in our code. |
How about this? |
No description provided.