Skip to content

fix(converter): update subject and message name retrieval in ConverterFactory and WorkerConfig (#2831) #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

fix(converter): update subject and message name retrieval in ConverterFactory and WorkerConfig (#2831) #2832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/java/kafka/automq/table/process/convert/ConverterFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ public Converter createKeyConverter(String topic, WorkerConfig config) {
throw new IllegalArgumentException("WorkerConfig cannot be null");
}
TableTopicConvertType convertType = config.keyConvertType();
String subject = config.valueSubject();
String messageName = config.valueMessageFullName();
String subject = config.keySubject();
String messageName = config.keyMessageFullName();
return createConverterByType(topic, convertType, subject, messageName, true);
}

Expand Down
12 changes: 8 additions & 4 deletions core/src/main/java/kafka/automq/table/worker/WorkerConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,19 +64,23 @@ public TableTopicConvertType keyConvertType() {
}

public String valueSubject() {
return config.valueSchemaLatestConfig.get("subjet").toString();
Object subject = config.valueSchemaLatestConfig.get("subject");
return subject != null ? subject.toString() : null;
}

public String valueMessageFullName() {
return config.valueSchemaLatestConfig.get("message.full.name").toString();
Object name = config.valueSchemaLatestConfig.get("message.full.name");
return name != null ? name.toString() : null;
}

public String keySubject() {
return config.keySchemaLatestConfig.get("subjet").toString();
Object subject = config.keySchemaLatestConfig.get("subject");
return subject != null ? subject.toString() : null;
}

public String keyMessageFullName() {
return config.keySchemaLatestConfig.get("message.full.name").toString();
Object name = config.keySchemaLatestConfig.get("message.full.name");
return name != null ? name.toString() : null;
}

public TableTopicTransformType transformType() {
Expand Down
Loading