Skip to content

fix(zerozone2): close snapshotReadPartitionsManager #2867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
+3 −1
Merged

fix(zerozone2): close snapshotReadPartitionsManager #2867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/src/main/java/kafka/automq/zerozone/ZeroZoneTrafficInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ public ZeroZoneTrafficInterceptor(
public void close() {
if (closed.compareAndSet(false, true)) {
committedEpochManager.close();
snapshotReadPartitionsManager.close();
}
}

Expand Down
3 changes: 2 additions & 1 deletion core/src/main/scala/kafka/server/streamaspect/ElasticKafkaApis.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,9 +827,10 @@ class ElasticKafkaApis(
}

override def handleOffsetForLeaderEpochRequest(request: RequestChannel.Request): Unit = {
val cf = snapshotAwaitReadySupplier.get()
offsetForLeaderEpochExecutor.execute(() => {
// Await new snapshots to be applied to avoid consumers finding the endOffset jumping back when the snapshot-read partition leader changes.
snapshotAwaitReadySupplier.get().join()
cf.join()
super.handleOffsetForLeaderEpochRequest(request)
})
}
Expand Down
Loading