Skip to content

fix(metrics): set the interval for the lazy-created histogram #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

fix(metrics): set the interval for the lazy-created histogram #2868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions s3stream/src/main/java/com/automq/stream/s3/metrics/Metrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ public void setup() {
.putAll(histogramAttrs)
.build();
this.shouldRecord = level.isWithin(globalConfig.getMetricsLevel());
histogram.setSnapshotInterval(globalConfig.getMetricsReportIntervalMs());
}
}
}
Expand Down
3 changes: 2 additions & 1 deletion s3stream/src/main/java/com/automq/stream/s3/metrics/wrapper/DeltaHistogram.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,13 @@
import org.HdrHistogram.Histogram;
import org.HdrHistogram.Recorder;

import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicLong;
import java.util.concurrent.atomic.LongAdder;
import java.util.function.BiPredicate;

public class DeltaHistogram {
private static final Long DEFAULT_SNAPSHOT_INTERVAL_MS = 5000L;
private static final Long DEFAULT_SNAPSHOT_INTERVAL_MS = TimeUnit.SECONDS.toMillis(30);
private final LongAdder cumulativeCount = new LongAdder();
private final LongAdder cumulativeSum = new LongAdder();
private final AtomicLong min = new AtomicLong(Long.MAX_VALUE);
Expand Down
1 change: 1 addition & 0 deletions s3stream/src/main/java/com/automq/stream/s3/metrics/wrapper/HistogramMetric.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ public HistogramMetric(MetricsLevel currentMetricsLevel, MetricsConfig metricsCo
public HistogramMetric(MetricsLevel currentMetricsLevel, MetricsConfig metricsConfig, Attributes extraAttributes) {
super(metricsConfig, extraAttributes);
this.deltaHistogram = new DeltaHistogram();
this.deltaHistogram.setSnapshotInterval(metricsConfig.getMetricsReportIntervalMs());
this.currentMetricsLevel = currentMetricsLevel;
}

Expand Down
Loading