-
Notifications
You must be signed in to change notification settings - Fork 497
feat(metrics): integrate new metrics for table delay, fields per second, and event loop busy ratio #2876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR integrates new metrics for table delay, fields per second, and event loop busy ratio by implementing a new gauge system using OpenTelemetry and adding network bandwidth limiting for Iceberg writes.
- Adds new LongGaugeBundle and DoubleGaugeBundle classes to the Metrics system for observable gauge management
- Refactors table metrics from static maps to individual gauge instances for better resource management
- Integrates network bandwidth limiting into IcebergWriter with the new ICEBERG_WRITE throttle strategy
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
ThrottleStrategy.java | Adds ICEBERG_WRITE throttle strategy enum value |
Metrics.java | Implements new LongGaugeBundle and DoubleGaugeBundle classes for gauge management |
IcebergWriter.java | Integrates network bandwidth limiting with permit acquisition and consumption tracking |
EventLoops.java | Adds busy ratio tracking and gauge recording for event loops |
TableTopicMetricsManager.java | Refactors from static suppliers to individual gauge registration system |
TableCoordinator.java | Updates to use new gauge-based metrics instead of static maps |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
core/src/main/java/kafka/automq/table/worker/IcebergWriter.java
Outdated
Show resolved
Hide resolved
…nd, and event loop busy ratio (#2876) * feat(metrics): integrate new metrics for table topic delay and fields per second * feat(metrics): add event loop busy ratio metric for table worker * feat(network): enhance network permit handling and improve blocking consumption
No description provided.