Skip to content

Conversation

Gezi-lzq
Copy link
Contributor

No description provided.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates new metrics for table delay, fields per second, and event loop busy ratio by implementing a new gauge system using OpenTelemetry and adding network bandwidth limiting for Iceberg writes.

  • Adds new LongGaugeBundle and DoubleGaugeBundle classes to the Metrics system for observable gauge management
  • Refactors table metrics from static maps to individual gauge instances for better resource management
  • Integrates network bandwidth limiting into IcebergWriter with the new ICEBERG_WRITE throttle strategy

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
ThrottleStrategy.java Adds ICEBERG_WRITE throttle strategy enum value
Metrics.java Implements new LongGaugeBundle and DoubleGaugeBundle classes for gauge management
IcebergWriter.java Integrates network bandwidth limiting with permit acquisition and consumption tracking
EventLoops.java Adds busy ratio tracking and gauge recording for event loops
TableTopicMetricsManager.java Refactors from static suppliers to individual gauge registration system
TableCoordinator.java Updates to use new gauge-based metrics instead of static maps

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Gezi-lzq Gezi-lzq merged commit ae63696 into main Sep 23, 2025
6 checks passed
@Gezi-lzq Gezi-lzq deleted the feat/table-topic-metric branch September 23, 2025 02:23
Gezi-lzq added a commit that referenced this pull request Sep 23, 2025
…nd, and event loop busy ratio (#2876)

* feat(metrics): integrate new metrics for table topic delay and fields per second

* feat(metrics): add event loop busy ratio metric for table worker

* feat(network): enhance network permit handling and improve blocking consumption
Gezi-lzq added a commit that referenced this pull request Sep 23, 2025
…nd, and event loop busy ratio (#2876) (#2881)

* feat(metrics): integrate new metrics for table topic delay and fields per second

* feat(metrics): add event loop busy ratio metric for table worker

* feat(network): enhance network permit handling and improve blocking consumption
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants