Skip to content

fix(wal): limit bulk upload delay #2887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
+7 −6
Merged

fix(wal): limit bulk upload delay #2887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions s3stream/src/main/java/com/automq/stream/s3/wal/impl/object/DefaultWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,12 +559,13 @@ class Bulk {
public Bulk(long baseOffset) {
this.startNanos = time.nanoseconds();
this.baseOffset = baseOffset;
long forceUploadNanos = lastBulkForceUploadNanos + batchNanos;
long forceUploadDelayNanos = Math.max(
// Try batch the requests in a short time window to save the PUT API.
minBulkUploadIntervalNanos,
forceUploadNanos - startNanos
);
long forceUploadDelayNanos = Math.min(
Math.max(
// Try batch the requests in a short time window to save the PUT API.
minBulkUploadIntervalNanos,
lastBulkForceUploadNanos + batchNanos - startNanos
),
batchNanos);
lastBulkForceUploadNanos = startNanos + forceUploadDelayNanos;
SCHEDULE.schedule(() -> forceUploadBulk(this), forceUploadDelayNanos, TimeUnit.NANOSECONDS);
}
Expand Down
Loading