test(iceberg): ensure iceberg rest catalog supports custom headers passing th… #2892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rough headers to iceberg library
rmannibucau
requested review from
superhx,
Gezi-lzq,
1sonofqiu and
woshigaopp
as code owners
rmannibucau
changed the title
|
|
Gezi-lzq
reviewed
Sep 24, 2025
| ))); | ||
| final var catalog = new CatalogFactory.Builder(config).build(); | ||
| assertInstanceOf(RESTCatalog.class, catalog).close(); | ||
| assertEquals(List.of("GET /v1/config?warehouse=s3://my_bucket/iceberg"), requests); |
There was a problem hiding this comment.
Nice coverage here with the REST catalog setup. To make it bulletproof, could we also assert that the custom header (x-custom: my-x) is present on the request? Right now the handler only checks the URL, so the test would still pass if the header weren’t forwarded.
There was a problem hiding this comment.
good catch (was the original intent), updated
Gezi-lzq
approved these changes
Sep 25, 2025
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rough headers to iceberg library
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)