-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace small-menu.js with navigation.js inspired by Twenty Twelve. #66
Conversation
Doesn't use jQuery, slightly easier to understand, uses a media query for max-width, rather than JS events making it faster to respond.
I found this slightly harder to understand but it seems like it would be cleaner/faster. If it doesn't break anything, plus 1 from me. |
I would also like to change the How do you feel about changing the tag? What do you think the new tag should be? |
It's a HTML5 semantics thing, using headings inside sectioning elements, and using h1 for the first heading inside of each sectioning element for consistency, sanity, and portability (you can move that block of code around the document and the heading will always be correctly nested). |
@ianstewart oh, in that case it makes perfect sense, thanks for explaining it :) |
This is a good addition. I have used this on a few themes now and it would be nice not to have to manually switch it out. |
There are plenty of themes that don't use jQuery for their functionality, so it seems a bit like overkill to require jQuery to be loaded on all pages just for small-menu.js. |
+1 I used the menu script from Twenty Twelve in my last project and it works great! |
+1! |
I think we should convert to the navigation.js script from Twenty Twelve as soon as we can. The Jetpack mobile theme uses the same small-menu.js as _s, and there were reports of it not working properly in Firefox on Android devices. Switching it to Twenty Twelve's navigation.js fixed the problem. |
Replace small-menu.js with navigation.js inspired by Twenty Twelve.
Autoload mu-plugins
Doesn't use jQuery, slightly easier to understand (is it?), uses a media query for max-width, rather than JS events making it faster to respond.
I have a feeling this could be cleaned up even more. Thoughts?