Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout improvements #134

Merged
merged 10 commits into from
Nov 22, 2022
Merged

Layout improvements #134

merged 10 commits into from
Nov 22, 2022

Conversation

psrpinto
Copy link
Member

@psrpinto psrpinto commented Nov 18, 2022 •
edited
Loading

Fixes #122

Summary of changes

  • Remove scrollbars in pre-session screens (session selection, login, logout)
  • Remove drop shadow around pre-session screens

Screenshots

Before After
Screenshot 2022-11-21 at 15 28 51 Screenshot 2022-11-21 at 15 35 15
Screenshot 2022-11-21 at 15 30 14 Screenshot 2022-11-21 at 15 34 51
Screenshot 2022-11-21 at 15 28 36 Screenshot 2022-11-21 at 15 35 41
Screenshot 2022-11-21 at 15 49 10 Screenshot 2022-11-21 at 15 49 02

@psrpinto psrpinto self-assigned this Nov 18, 2022
@psrpinto psrpinto force-pushed the styling-improvements branch from 2c93798 to 16c1ed7 Compare November 21, 2022 15:36
@psrpinto psrpinto force-pushed the styling-improvements branch from 16c1ed7 to 475a7a1 Compare November 21, 2022 15:40
@psrpinto psrpinto marked this pull request as ready for review November 21, 2022 15:50
@psrpinto psrpinto requested review from ashfame and akirk November 21, 2022 15:50
akirk
akirk approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually looks great!

@psrpinto psrpinto merged commit b61cd96 into main Nov 22, 2022
@psrpinto psrpinto deleted the styling-improvements branch November 22, 2022 14:06
@psrpinto psrpinto mentioned this pull request Dec 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akirk akirk akirk approved these changes

@ashfame ashfame Awaiting requested review from ashfame

Assignees

@psrpinto psrpinto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Styling improvements
2 participants
@psrpinto @akirk