Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to 0.6.4 and use publish task for Gradle #27

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

oguzkocer
Copy link
Contributor

Using publishPluginMavenPublicationToS3Repository Gradle task was not triggering publishConfigurePluginMarkerMavenPublicationToS3Repository which is necessary to publish the plugin marker artifacts. Instead of adding the publishConfigurePluginMarkerMavenPublicationToS3Repository to the task list, I decided to simply use the publish task, which is what we do in most repositories. I was originally concerned with publish task publishing other publications, so I wanted to use a specific task to future proof it. However, it's probably not something worth worrying about, so I think we should simplify the process.

@oguzkocer oguzkocer requested a review from jkmassel August 2, 2022 20:30
Copy link
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this'll work for all the non-gradle stuff. I trust you for the gradle task 🙂

@oguzkocer oguzkocer merged commit 8ba72fe into trunk Aug 2, 2022
@oguzkocer oguzkocer deleted the release/0.6.4 branch August 2, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants