Draft PR for peeking with guest login #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! So now the question is how |
ashfame
force-pushed
the
peeking_with_guest_login
branch
from
efbc2f7
to
363a02b
Compare
ashfame
commented
Mar 3, 2023
psrpinto
approved these changes
Mar 6, 2023
4 tasks
ashfame
force-pushed
the
peeking_with_guest_login
branch
from
363a02b
to
2efd344
Compare
ashfame
force-pushed
the
peeking_with_guest_login
branch
from
2efd344
to
36edfd4
Compare
akirk
approved these changes
Mar 22, 2023
ashfame
added
the
upstream-contribution-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (not meant for merge) highlights the differences needed in Hydrogen to make peeking with guest login work.
Run Automattic/chatrix#193 branch to run guest peeking