-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker stuff for new mariadb:lts #37659
Conversation
It seems that MariaDB released a new lts, which dropped a bunch of the compatibility mysql-named symlinks from their docker image. This broke a bunch of our stuff. * Change the health command passed to Docker. * Use new names in the dev env db upgrade wrapper script. * Pass the correct `command` to the dev env DB container. Also I noticed our tests workflow was still using MySQL 5.6, while WordPress now requires either MySQL 8.0+ or MariaDB 10.4+. Updated to the latter there too.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
@@ -198,7 +198,7 @@ jobs: | |||
MARIADB_ROOT_PASSWORD: wordpress | |||
ports: | |||
- 3306:3306 | |||
options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=5 | |||
options: --health-cmd="healthcheck.sh --su-mysql --connect --innodb_initialized" --health-interval=10s --health-timeout=5s --health-retries=5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why --su-mysql
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied from the first example at https://mariadb.com/kb/en/using-healthcheck-sh/#examples, since it seemed to work.
Proposed changes:
It seems that MariaDB released a new lts, which dropped a bunch of the compatibility mysql-named symlinks from their docker image. This broke a bunch of our stuff.
command
to the dev env DB container.Also I noticed our tests workflow was still using MySQL 5.6, while WordPress now requires either MySQL 8.0+ or MariaDB 10.4+. Updated to the latter there too.
Other information:
Jetpack product discussion
p1717161929313609/1717160529.942769-slack-C034JEXD1RD
Does this pull request change what data or activity we track or use?
No
Testing instructions:
docker pull mariadb:lts
, then make sure thatjetpack docker down
andjetpack docker up
still work.