Fix back button behavior when using image carousel - take2 #5168

karpad3 · 2016-09-12T19:48:31Z

This pull request should replace Pull Request 4825.
The other request has a bug: when using the back or forward buttons while the gallery is open, history messed up after gallery close.
Please make sure you cancel the integration of the other pull request!

jeherve · 2016-09-26T09:43:30Z

Fixes #2703

dereksmart · 2016-11-09T21:29:58Z

modules/carousel/jetpack-carousel.js

@@ -1426,6 +1424,11 @@ jQuery(document).ready(function($) {
 			return;
 		}

+		if ( window.location.hash && gallery && !gallery.opened && history.back) {


missing whitespace -- should be a space after the ! and before the closing parenths

dereksmart · 2016-11-09T21:30:57Z

Seemed to work as expected.

Opened carousel
navigated around (clicking back while carousel was open)
Closing the carousel removes the query params
Clicking back after closing takes me to the previous page

Just some very minor missing whitespace.

dereksmart · 2016-11-09T21:45:09Z

marked as green -- we can fix whitespace in another PR if this gets merged

* Changelog: add PRs belonging to 4.4. Changelog: add #5186 Changelog: add #3425 Changelog: add #5365 Changelog: add #5428 Changelog: add #3358 Changelog: add #5183 Changelog: add #4881 Changelog: add #5286 Changelog: add #5395 Changelog: add #5419 Changelog: add #5437 Changelog: add #5291 Update version number Changelog: add #5476, #5413, #5409, #5355, #5348 Changelog: add #5381 Changelog: add #5412 Changelog: add #5386 Changelog: add #5250 CHangelog: add #5011 Changelog: add #5090 Changelog: add IDC fixes. Changelog: add #5259 CHangelog: add #5186 Changelog: add #5236 Changelog: add #5284 Changelog: add #5366 Changelog: add #5382 Changelog: add #5396 Changelog: add #5405 Changelog: add #4897 Changelog: add #5289 Added a changelog entry about #5534. Added a changelog entry about #5479. Added a changelog entry about #5454. Added a changelog entry about #5434. Added a changelog entry about #5408. Added a changelog entry about #5369. Added a changelog entry about #5350. Added a changelog entry about #5324. Added a changelog entry about #5319. Added a changelog entry about #5310. Added a changelog entry about #5282. Added a changelog entry about #5176. Added a changelog entry about #3515. Added a changelog entry about #1542. Added a changelog entry about #5316. Added a changelog entry about #3188. Changelog: add #4987 Changelog: add #5270 Changelog: add #5225 Changelog: add #5507 Changelog: add #5432 Changelog: add #5473 Changelog: add #5392 Changelog: add #5222 Changelog: add #5457 Changelog: add #5423 Changelog: add #5332 Changelog: add #3853 Changelog: add #5237 Changelog: add #5307 Changelog: move up release headliner. Changelog: add #5375 CHangelog: add #5496 Changelog: add #5528 Changelog: add #5537 Changelog: remove new Settings, they're punted to 4.5. Changelog: move release headliner to the top. Changelog: add testing list. Changelog: add #4953 Changelog: add #5575 Changelog: add #5573 Changelog: add #5345 * Changelog: add #5168

diff --git a/changelog.txt b/changelog.txt index 78ee043..a03cdb9 100644 --- a/changelog.txt +++ b/changelog.txt @@ -1,4 +1,30 @@ -== Changelog == +== Changelog == + += 4.4 = + +**Enhancements** + +* Additional unit tests have been added to improve Jetpack's development process and stability. +* Custom post types have been added to the REST API output. +* Many of the screenshots throughout the plugin have been replaced by SVGs in order to make Jetpack smaller. +* New endpoints have been added to allow the installation of plugins and themes via the API. +* New filters to improve Jetpack's extensibility: jetpack_auth_type, jetpack_nova_menu_item_loop_open_element, jetpack_nova_menu_item_loop_close_element, jetpack_nova_menu_item_loop_class, jetpack_markdown_preserve_shortcodes, jpp_allow_login, jetpack_sharing_headline_html, jetpack_tiled_gallery_template, jetpack_tiled_gallery_partial, jetpack_top_posts_widget_permalink, jetpack_top_posts_widget_permalink, jetpack_widget_visibility_tax_args. +* New widget: "Google Translate" to allow users to translate your site into their own language. +* New widget: "My Community" where you can see who recently interacted with your site. +* One of the biggest issues facing Jetpack users for years now has been difficulties in moving sites from one domain name to another. This update makes strides towards improving that process. +* Photon now uses HTTPS by default. Secure all the things! +* There are now helpful hints throughout the admin interface to make Jetpack easier to use. +* We now allow you to embed from Pinterest. +* We've added a new feature: SEO Tools, available to Jetpack Professional subscribers. +* We've made numerous improvements to the data sync process. +* Welcome back to the Site Stats link in your admin menu! + +**Bug Fixes:** + +* Fixed link to Akismet settings. +* Improved compatibility between Infinite Scroll and WPML, props Vuk Vuković. +* Move email notification settings back with the other email settings in the Discussion Settings. +* Various minor performance/compatibility fixes. = 4.3.2 = diff --git a/readme.txt b/readme.txt index 403b6df..47e2635 100644 --- a/readme.txt +++ b/readme.txt @@ -79,83 +79,27 @@ There are opportunities for developers at all levels to contribute. [Learn more **Enhancements** -* Brand new SEO Tools module. #5307 -* Shortcodes: added Pinterest embeds. #5437 -* VideoPress: refreshed admin interface, seamless integration with the core Media manager, tied with Jetpack Plans. #5457 - -* Admin Page: added a filter to manage if the newly connected user should go to WordPress.com or not. #5319 -* Admin Page: added links to pages where users can fix problems with Akismet and update plugins. #5176 -* Admin Page: added helpful hints to make Jetpack easier to use. #5479 -* Admin Page: redesign Development mode banner. #5186 -* Admin Page: removed unnecessarily loaded theme compatibility files. #5454 -* Admin Page: when user is non admin, Protect module is inactive and they have no access to Stats, don't break the UI trying to go to At a Glance which isn't accessible by them and instead display Apps tab. #5395 -* Admin Page: use SVGs instead of raster images to improve performance. #5419 -* Admin Page: improve design when Development mode is active. #5186 -* Admin Page: improve contrast for better accessibility. #5236 -* Carousel: moved close icon location to the top right. #5237 -* Carousel: change the behavior of the browser's back button after closing a gallery. #5168 -* Contact Form: add horizontal line between message content and meta data. #5270 -* Custom Post Types: added custom posts to the output of the WordPress REST API. #5434 -* Custom Post Types: made Nova post markup more flexible by adding new filters. #1542 -* Debug Page: add information about Development mode. #5225 -* Documentation: Improvements to README.md sections about development workflow and clarification about Node versions required for the build tasks. #5428 -* Development: added tests for Jetpack API endpoints for the WordPress REST API. #5310 -* Development: added tests for various constants in use by Jetpack. #5350 -* General: improve the display of the connection banners to explain to site owners why they should connect to WordPress.com. #5473 -* JSON API: add new API endpoint to allow installing a plugin via the API, from a zip file. #5507 -* JSON API: add new API endpoint to allow installing a theme via the API. #5537 -* JSON API: customize the theme endpoint to allow installing WordPress.com themes. #5392 -* Markdown: add new filter to allow site owners to parse content inside shortcodes. #5573 -* Photon: now using HTTPS to retrieve images by default. #5534 -* Protect: added a filter to skip IP address checking in favor of another security check. #5369 -* Publicize: only trigger Publicize for Post Types that support it. #5381 -* Related Posts: add posts to the WP REST API Post Response. #3425 -* Sharing / Likes: add new filter to customize the heading HTML. #5011 -* Sharing: better video tags for Video posts including VideoPress videos. #3853 -* Site Icon: added the site icon property to the output of the settings API endpoint. #5282 -* SSO: Extend logged in expiration to 1 year. #5259 -* Sync: added an API endpoint to examine the current state of scheduled sync jobs. #5324 -* Sync: improve synchronization on sites with a custom implementation of Cron. -* Sync: disable Sync via Cron. #5528 -* Tests: introduce GUI tests for the React components in Jetpack. #5496 -* Tiled Galleries: add filter to override the default Tiled Gallery template files. #5090 -* Widgets: new 'My Community' widget displaying people who recently interacted with your site. #3358 -* Widgets: new Google Translate widget. #5386 -* Widgets: new Flickr option in the Social Media Icons Widget. #5250 -* Widgets: new 'WordPress.org' option in the Social Media Icons Widget. #5183 -* Widgets: add new `jetpack_top_posts_widget_permalink` filter to the permalinks in Top Posts Widget. #4881 -* Widgets: remove title attributes from the Social Media Icons Widget. #5286 -* Widget Visibility: add a filter to the get_taxonomies arguments. #5222 - -**Improved Compatibility:** - -* Infinite Scroll: improve compatibility with WPML and language slugs in permalinks. #4953 -* Open Graph: add SEO by Squirrly TM to the list of conflicting plugins. #5365 -* Sharing: fix conflict between the Email button and the Autoptimize plugin. #5291 -* Sync: avoid conflicts with the Photo Gallery plugin. #5412 -* Sync: avoid conflicts with IDX support plugins such as IMPress for IDX Broker and dsIDXpress for IDX. #5636 -* Several improvements to avoid issues when cloning / duplicating sites, creating staging sites, or changing your site URL. +* Additional unit tests have been added to improve Jetpack's development process and stability. +* Custom post types have been added to the REST API output. +* Many of the screenshots throughout the plugin have been replaced by SVGs in order to make Jetpack smaller. +* New endpoints have been added to allow the installation of plugins and themes via the API. +* New filters to improve Jetpack's extensibility: jetpack_auth_type, jetpack_nova_menu_item_loop_open_element, jetpack_nova_menu_item_loop_close_element, jetpack_nova_menu_item_loop_class, jetpack_markdown_preserve_shortcodes, jpp_allow_login, jetpack_sharing_headline_html, jetpack_tiled_gallery_template, jetpack_tiled_gallery_partial, jetpack_top_posts_widget_permalink, jetpack_top_posts_widget_permalink, jetpack_widget_visibility_tax_args. +* New widget: "Google Translate" to allow users to translate your site into their own language. +* New widget: "My Community" where you can see who recently interacted with your site. +* One of the biggest issues facing Jetpack users for years now has been difficulties in moving sites from one domain name to another. This update makes strides towards improving that process. +* Photon now uses HTTPS by default. Secure all the things! +* There are now helpful hints throughout the admin interface to make Jetpack easier to use. +* We now allow you to embed from Pinterest. +* We've added a new feature: SEO Tools, available to Jetpack Professional subscribers. +* We've made numerous improvements to the data sync process. +* Welcome back to the Site Stats link in your admin menu! **Bug Fixes:** -* Admin Page: fix URL to Akismet Settings. #5332 -* Admin Page: do not load unnecessary file on connection page. #5284 -* Admin Page: avoid errors when page is loaded by secondary users. #5366 -* Admin Page: update the Create Account link from the Admin Page's dashboard to direct the user into a connect screen that asks them to sign up by being aware that the user clicked the Create Account instead of just the connect button. #5382 -* Admin Page: for non-admin users, when site is in Dev Mode, a Jetpack link leading to a blank page with a message "Sorry, you are not allowed to access this page." is no longer displayed. #5396 -* Admin Page: fix PHP warning when roles allowed to see Stats don't exist or haven't been saved yet. #5432 -* Admin Page: fix issue where certain administrative page actions would fail with sites using index permalinks. #5345 -* Contact Forms: fixed shortcode properties passing when using do_shortcode. #3188 -* Contact Forms: restricted access to feedback posts from the WordPress REST API. #5408 -* JSON API: avoid errors when the Sharing module isn't available. #5423 -* Likes: move email notification settings back with the other email settings in the Discussion Settings. #4987 -* Site Icon: not using a site icon as fallback version if it is too small. #3515 -* SSO: remove unnecessary styles for nonexistent profile UI. #5289 -* Sitemaps: make sure sitemaps always use absolute paths for images. #5375 -* Sync: avoid counting users on very large networks. #5575 -* Subscriptions: fix PHP warnings when user subscribes to comments. #4897 -* Subscriptions: fixed the "do not send" checkbox status in draft mode so it would stay checked. #5689 -* Widgets: fixed Instagram widget minimum width rule to actually use the minimum instead of maximum. #5316 +* Fixed link to Akismet settings. +* Improved compatibility between Infinite Scroll and WPML, props Vuk Vuković. +* Move email notification settings back with the other email settings in the Discussion Settings. +* Various minor performance/compatibility fixes. = 4.3.2 =

Fix back button behavior when using image carousel - take2

339c46d

This was referenced Sep 12, 2016

Viewing images in carousel gallery breaks the back button #2703

Closed

Fix back button behavior when using image carousel #4825

Closed

jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Sep 26, 2016

jeherve added this to the 4.4 milestone Sep 26, 2016

dereksmart reviewed Nov 9, 2016

View reviewed changes

dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Nov 9, 2016

samhotchkiss merged commit 3d6f8a7 into Automattic:master Nov 9, 2016

jeherve added a commit that referenced this pull request Nov 10, 2016

Changelog: add #5168

c211584

jeherve added the [Status] Has Changelog label Nov 10, 2016

jeherve mentioned this pull request Mar 7, 2017

Carousel: Closing Carousel view goes back to Previous page #6244

Open

karpad3 deleted the carousel_back_button_fix_take2 branch May 25, 2017 11:58

kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020

matticbot added the Touches WP.com Files label Oct 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix back button behavior when using image carousel - take2 #5168

Fix back button behavior when using image carousel - take2 #5168

karpad3 commented Sep 12, 2016

jeherve commented Sep 26, 2016

dereksmart Nov 9, 2016

dereksmart commented Nov 9, 2016

dereksmart commented Nov 9, 2016

Fix back button behavior when using image carousel - take2 #5168

Fix back button behavior when using image carousel - take2 #5168

Conversation

karpad3 commented Sep 12, 2016

jeherve commented Sep 26, 2016

dereksmart Nov 9, 2016

Choose a reason for hiding this comment

dereksmart commented Nov 9, 2016

dereksmart commented Nov 9, 2016