Updates module settings positions and renames tabs. #5405

zinigor · 2016-10-24T13:46:32Z

Changes proposed in this PR

Introduced two new tabs: Discussion and Traffic
Removed General, Appearance and Engagement tabs
Rearranged module settings according to the new tabs

Testing

Make sure all module cards work as before as an admin.
Make sure all module cards and tabs work as before as a non-admin.
Make sure things work in development mode.
Make sure things work with active Jetpack plans.

Related discussion: p6TEKc-HQ-p2

According to the new Settings UI concept there will be no General tab and the Engagement tab will be named Discussion.

eliorivero

There are things like Infinite Scroll that should be in Traffic.
Maybe Mobile Theme should be in that tab too.

eliorivero · 2016-10-26T21:24:38Z

_inc/client/main.jsx

@@ -169,33 +168,28 @@ const Main = React.createClass( {
 				break;
 			case '/settings':


This /settings case and /writing can be merged.

Thanks, it totally slipped my mind that it could have been done this way.

eliorivero · 2016-10-26T21:29:17Z

_inc/client/components/navigation-settings/index.jsx

-						path="#general"
-						selected={ ( this.props.route.path === '/general' || this.props.route.path === '/settings' ) }>
-						{ __( 'General', { context: 'Navigation item.' } ) }
+						path="#settings"


It's counter intuitive that this path is #settings. It should be #writing.

Thanks, fixed that, plus fixed the view for authors.

eliorivero · 2016-10-26T21:29:58Z

_inc/client/components/navigation-settings/index.jsx

-						selected={ ( this.props.route.path === '/general' || this.props.route.path === '/settings' ) }>
-						{ __( 'General', { context: 'Navigation item.' } ) }
+						path="#settings"
+						selected={ ( this.props.route.path === '/settings' || this.props.route.path === '/settings' ) }>


This condition should check if it's /writing or /settings.

eliorivero · 2016-10-26T21:33:32Z

_inc/client/components/navigation-settings/index.jsx

-						selected={ ( this.props.route.path === '/general' || this.props.route.path === '/settings' ) }>
-						{ __( 'General', { context: 'Navigation item.' } ) }
+						path="#settings"
+						selected={ ( this.props.route.path === '/settings' || this.props.route.path === '/settings' ) }>


Same comments than above about path and condition

eliorivero · 2016-10-26T21:33:47Z

_inc/client/components/navigation-settings/index.jsx

-						selected={ this.props.route.path === '/engagement' }>
-						{ __( 'Engagement', { context: 'Navigation item.' } ) }
+						path="#settings"
+						selected={ ( this.props.route.path === '/settings' || this.props.route.path === '/settings' ) }>


Same comments than above about path and condition

samhotchkiss · 2016-10-31T18:42:04Z

#5461

Changelog: add #5186 Changelog: add #3425 Changelog: add #5365 Changelog: add #5428 Changelog: add #3358 Changelog: add #5183 Changelog: add #4881 Changelog: add #5286 Changelog: add #5395 Changelog: add #5419 Changelog: add #5437 Changelog: add #5291 Update version number Changelog: add #5476, #5413, #5409, #5355, #5348 Changelog: add #5381 Changelog: add #5412 Changelog: add #5386 Changelog: add #5250 CHangelog: add #5011 Changelog: add #5090 Changelog: add IDC fixes. Changelog: add #5259 CHangelog: add #5186 Changelog: add #5236 Changelog: add #5284 Changelog: add #5366 Changelog: add #5382 Changelog: add #5396 Changelog: add #5405 Changelog: add #4897 Changelog: add #5289 Added a changelog entry about #5534. Added a changelog entry about #5479. Added a changelog entry about #5454. Added a changelog entry about #5434. Added a changelog entry about #5408. Added a changelog entry about #5369. Added a changelog entry about #5350. Added a changelog entry about #5324. Added a changelog entry about #5319. Added a changelog entry about #5310. Added a changelog entry about #5282. Added a changelog entry about #5176. Added a changelog entry about #3515. Added a changelog entry about #1542. Added a changelog entry about #5316. Added a changelog entry about #3188. Changelog: add #4987 Changelog: add #5270 Changelog: add #5225 Changelog: add #5507 Changelog: add #5432 Changelog: add #5473 Changelog: add #5392 Changelog: add #5222 Changelog: add #5457 Changelog: add #5423 Changelog: add #5332 Changelog: add #3853 Changelog: add #5237 Changelog: add #5307 Changelog: move up release headliner. Changelog: add #5375 CHangelog: add #5496 Changelog: add #5528 Changelog: add #5537 Changelog: remove new Settings, they're punted to 4.5. Changelog: move release headliner to the top. Changelog: add testing list. Changelog: add #4953 Changelog: add #5575 Changelog: add #5573 Changelog: add #5345

* Changelog: add PRs belonging to 4.4. Changelog: add #5186 Changelog: add #3425 Changelog: add #5365 Changelog: add #5428 Changelog: add #3358 Changelog: add #5183 Changelog: add #4881 Changelog: add #5286 Changelog: add #5395 Changelog: add #5419 Changelog: add #5437 Changelog: add #5291 Update version number Changelog: add #5476, #5413, #5409, #5355, #5348 Changelog: add #5381 Changelog: add #5412 Changelog: add #5386 Changelog: add #5250 CHangelog: add #5011 Changelog: add #5090 Changelog: add IDC fixes. Changelog: add #5259 CHangelog: add #5186 Changelog: add #5236 Changelog: add #5284 Changelog: add #5366 Changelog: add #5382 Changelog: add #5396 Changelog: add #5405 Changelog: add #4897 Changelog: add #5289 Added a changelog entry about #5534. Added a changelog entry about #5479. Added a changelog entry about #5454. Added a changelog entry about #5434. Added a changelog entry about #5408. Added a changelog entry about #5369. Added a changelog entry about #5350. Added a changelog entry about #5324. Added a changelog entry about #5319. Added a changelog entry about #5310. Added a changelog entry about #5282. Added a changelog entry about #5176. Added a changelog entry about #3515. Added a changelog entry about #1542. Added a changelog entry about #5316. Added a changelog entry about #3188. Changelog: add #4987 Changelog: add #5270 Changelog: add #5225 Changelog: add #5507 Changelog: add #5432 Changelog: add #5473 Changelog: add #5392 Changelog: add #5222 Changelog: add #5457 Changelog: add #5423 Changelog: add #5332 Changelog: add #3853 Changelog: add #5237 Changelog: add #5307 Changelog: move up release headliner. Changelog: add #5375 CHangelog: add #5496 Changelog: add #5528 Changelog: add #5537 Changelog: remove new Settings, they're punted to 4.5. Changelog: move release headliner to the top. Changelog: add testing list. Changelog: add #4953 Changelog: add #5575 Changelog: add #5573 Changelog: add #5345 * Changelog: add #5168

zinigor added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress Admin Page React-powered dashboard under the Jetpack menu labels Oct 24, 2016

zinigor added this to the 4.4 milestone Oct 24, 2016

zinigor self-assigned this Oct 24, 2016

zinigor mentioned this pull request Oct 24, 2016

Adds single buttons per each settings group. #5406

Closed

zinigor added 5 commits October 26, 2016 11:33

Added a new tab and renamed engagement.

793eac1

According to the new Settings UI concept there will be no General tab and the Engagement tab will be named Discussion.

Removed Engagement page class file.

1532d7a

Rearranged Security settings modules.

fc1d2a0

Added a Traffic tab.

d1b30b3

Removed the Appearance tab class file.

1997bda

zinigor force-pushed the update/module-placement branch from 81624de to 1997bda Compare October 26, 2016 09:19

zinigor added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Oct 26, 2016

MichaelArestad added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Oct 26, 2016

eliorivero added the [Status] Requires String Changes label Oct 26, 2016

eliorivero suggested changes Oct 26, 2016

View reviewed changes

jeherve added the [Status] Needs Changelog label Oct 27, 2016

zinigor added 2 commits October 27, 2016 17:29

Merged two identical switch cases.

9c62f23

Fixed the view for authors.

9aab367

jeherve added the [Pri] High label Oct 27, 2016

eliorivero approved these changes Nov 2, 2016

View reviewed changes

eliorivero removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Nov 2, 2016

zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Nov 3, 2016

zinigor merged commit 5b9a9f5 into master Nov 3, 2016

zinigor deleted the update/module-placement branch November 3, 2016 20:00

jeherve added [Status] Has Changelog and removed [Status] Needs Changelog labels Nov 7, 2016

kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates module settings positions and renames tabs. #5405

Updates module settings positions and renames tabs. #5405

zinigor commented Oct 24, 2016 •

edited by jeherve

eliorivero left a comment

eliorivero Oct 26, 2016

zinigor Oct 27, 2016

eliorivero Oct 26, 2016

zinigor Oct 27, 2016

eliorivero Oct 26, 2016

zinigor Oct 27, 2016

eliorivero Oct 26, 2016

zinigor Oct 27, 2016

eliorivero Oct 26, 2016

zinigor Oct 27, 2016

samhotchkiss commented Oct 31, 2016

		@@ -169,33 +168,28 @@ const Main = React.createClass( {
		break;
		case '/settings':

Updates module settings positions and renames tabs. #5405

Updates module settings positions and renames tabs. #5405

Conversation

zinigor commented Oct 24, 2016 • edited by jeherve

Changes proposed in this PR

Testing

eliorivero left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samhotchkiss commented Oct 31, 2016

zinigor commented Oct 24, 2016 •

edited by jeherve