Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer: adjusted padding #5983

Merged
merged 1 commit into from
Dec 22, 2016
Merged

Footer: adjusted padding #5983

merged 1 commit into from
Dec 22, 2016

Conversation

keoshi
Copy link
Contributor

@keoshi keoshi commented Dec 22, 2016

Changed padding from .75rem to 1rem.

Added more top and bottom padding for better readability.

Fixes #5982

Changes proposed in this Pull Request:

Before:
screen shot 2016-12-22 at 11 42 51 am

After:
screen shot 2016-12-22 at 11 44 42 am

Changed padding to .75rem to 1rem
@keoshi keoshi added Admin Page React-powered dashboard under the Jetpack menu [Status] Design Polish [Status] Needs Design Review Design has been added. Needs a review! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Dec 22, 2016
@keoshi keoshi added this to the 4.5 milestone Dec 22, 2016
@keoshi keoshi self-assigned this Dec 22, 2016
Copy link
Member

@jeffgolenski jeffgolenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. thanks for cleaning this up! Great job on your first PR @keoshi

@jeffgolenski jeffgolenski added [Status] Design Review Complete [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Design Review Design has been added. Needs a review! labels Dec 22, 2016
@jeffgolenski jeffgolenski merged commit 452e23a into master Dec 22, 2016
@jeffgolenski jeffgolenski deleted the enhance/footer-padding branch December 22, 2016 21:07
@jeffgolenski
Copy link
Member

@keoshi you went offline for the evening. I just merged this in real quick, so we don't forget about it. the checks passed and we're good to go!

@keoshi
Copy link
Contributor Author

keoshi commented Dec 22, 2016 via email

jeherve added a commit that referenced this pull request Dec 23, 2016
dereksmart pushed a commit that referenced this pull request Jan 17, 2017
@see 18012a3

Changelog: add #5976, #5978, #5983

Changelog: add #5917

Changelog: add #5832
dereksmart pushed a commit that referenced this pull request Jan 17, 2017
Changelog: add #5867

Changelog: add #5874

Changelog: add #5905

Changelog: add #5906

Changelog: add #5931

Changelog: add #5933

Changelog: add #5934

Bring over 4.4.2 changelog from branch-4.4

@see 18012a3

Changelog: add #5976, #5978, #5983

Changelog: add #5917

Changelog: add #5832

Changelog: add 4.4.2 release post link.

CHangelog: add #5457

Changelog: add #5487

Changelog: add #5708

Changelog: add #5879

Changelog: add #5932

Changelog: add #5963

Changelog: add #5968

Changelog: add #5996

Changelog: add #5998

Changelog: add #5999

Changelog: add #6012

Changelog: add #6013

Changelog: add #6014

Changelog: add #6015

Changelog: add #6023

Changelog: add #6024

Changelog: add #6030

Changelog: add #5465

CHangelog: add #6063

Changelog: add #6025

Changelog: add #5974

Changelog: add #6059

Changelog: add #6046

Changelog: add #5418

Changelog: move things around and add missing information.

Changelog: add #5565

Changelog: add #6087

Changelog: add #6095

Readme: add @tyxla to the list of contributors.

Improved changelog for your readability and enjoyment

updated the release date

finalizing the changelog with a few more edits
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Status] Design Review Complete [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin: Add more padding to footer
3 participants