Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit cron jobs to 30 seconds #5996

Merged
merged 1 commit into from
Jan 1, 2017
Merged

Conversation

gravityrail
Copy link
Contributor

@gravityrail gravityrail commented Dec 27, 2016

An alternative, less aggressive approach to #5995

Sets a default time limit of 30 seconds when sending sync requests via Cron, per (incremental / full) sync type.

This is designed to alleviate reported cases where sync is timing out under certain cron configurations on really large DBs. This is part of trying to make Jetpack Sync a better plugin citizen :)

For sites which want to move faster, the 30 seconds is configurable as a setting called cron_sync_time_limit

@gravityrail gravityrail added [Package] Sync [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Team] Poseidon labels Dec 27, 2016
@gravityrail gravityrail self-assigned this Dec 27, 2016
@gravityrail gravityrail removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Jan 1, 2017
@gravityrail gravityrail merged commit 6c69f0f into master Jan 1, 2017
@gravityrail gravityrail deleted the fix/limit-cron-sync-to-30-seconds branch January 1, 2017 20:03
@dereksmart
Copy link
Member

merged to 4.5 7c5fd80

@jeherve jeherve added this to the 4.5 milestone Jan 9, 2017
jeherve added a commit that referenced this pull request Jan 9, 2017
dereksmart pushed a commit that referenced this pull request Jan 17, 2017
CHangelog: add #5457

Changelog: add #5487

Changelog: add #5708

Changelog: add #5879

Changelog: add #5932

Changelog: add #5963

Changelog: add #5968

Changelog: add #5996

Changelog: add #5998

Changelog: add #5999

Changelog: add #6012

Changelog: add #6013

Changelog: add #6014

Changelog: add #6015

Changelog: add #6023

Changelog: add #6024

Changelog: add #6030

Changelog: add #5465

CHangelog: add #6063

Changelog: add #6025

Changelog: add #5974

Changelog: add #6059

Changelog: add #6046

Changelog: add #5418

Changelog: move things around and add missing information.

Changelog: add #5565

Changelog: add #6087

Changelog: add #6095
dereksmart pushed a commit that referenced this pull request Jan 17, 2017
Changelog: add #5867

Changelog: add #5874

Changelog: add #5905

Changelog: add #5906

Changelog: add #5931

Changelog: add #5933

Changelog: add #5934

Bring over 4.4.2 changelog from branch-4.4

@see 18012a3

Changelog: add #5976, #5978, #5983

Changelog: add #5917

Changelog: add #5832

Changelog: add 4.4.2 release post link.

CHangelog: add #5457

Changelog: add #5487

Changelog: add #5708

Changelog: add #5879

Changelog: add #5932

Changelog: add #5963

Changelog: add #5968

Changelog: add #5996

Changelog: add #5998

Changelog: add #5999

Changelog: add #6012

Changelog: add #6013

Changelog: add #6014

Changelog: add #6015

Changelog: add #6023

Changelog: add #6024

Changelog: add #6030

Changelog: add #5465

CHangelog: add #6063

Changelog: add #6025

Changelog: add #5974

Changelog: add #6059

Changelog: add #6046

Changelog: add #5418

Changelog: move things around and add missing information.

Changelog: add #5565

Changelog: add #6087

Changelog: add #6095

Readme: add @tyxla to the list of contributors.

Improved changelog for your readability and enjoyment

updated the release date

finalizing the changelog with a few more edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants